[C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to nullptr in src/…

[C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to  nullptr in src/cc [part-3]

BUG =

[ARUNKK, 2014-10-09 09:13:24]

kulkarni.a@samsung.com changed reviewers:
+ danakj@chromium.org

[ARUNKK, 2014-10-09 09:13:25]

PTAL.

[danakj, 2014-10-09 16:01:39]

please fix comments and run git cl format as per our presubmit warnings

[ARUNKK, 2014-10-10 05:25:52]

On 2014/10/09 16:01:39, danakj wrote:
> please fix comments and run git cl format as per our presubmit warnings

Thanks for review.
All the presubmit error are resolved .
PTAL.

[ARUNKK, 2014-10-10 12:56:38]

kulkarni.a@samsung.com changed reviewers:
+ reveman@chromium.org

[ARUNKK, 2014-10-10 12:56:39]

PTAL.

[Avi (use Gerrit), 2014-10-10 16:55:18]

Your change description makes no sense. "[C++11 Allowed Features] Declares a
type-safe null pointer converting from NULL to  nullptr". This change does not
declare any pointers. This description seems to mash together two sentences:
"C++11 declares a type safe null pointer" and "This change converts from NULL to
nullptr". Please rewrite it to be grammatical English.

Also, if we’re doing a bulk conversion from NULL to nullptr, we should have a
master BUG tying this all together.

[danakj, 2014-10-10 17:03:22]

https://codereview.chromium.org/638353002/diff/130001/cc/resources/picture.h
File cc/resources/picture.h (right):

https://codereview.chromium.org/638353002/diff/130001/cc/resources/picture.h#...
cc/resources/picture.h:50: RECORD_WITH_SK_nullptr_CANVAS,
undo this

[danakj, 2014-10-10 17:28:46]

BTW have you considered using clang-modernize to do this instead of a search and
replace?

https://codereview.chromium.org/638353002/diff/130001/cc/output/software_outp...
File cc/output/software_output_device.h (right):

https://codereview.chromium.org/638353002/diff/130001/cc/output/software_outp...
cc/output/software_output_device.h:71: // hardware vsync. Return nullptr if a
provider doesn't exist.
just use null

https://codereview.chromium.org/638353002/diff/130001/cc/output/software_rend...
File cc/output/software_renderer.cc (right):

https://codereview.chromium.org/638353002/diff/130001/cc/output/software_rend...
cc/output/software_renderer.cc:429: // |resource_provider_| can be nullptr in
resourceless software draws, which
just use null

https://codereview.chromium.org/638353002/diff/130001/cc/resources/picture_la...
File cc/resources/picture_layer_tiling.cc (right):

https://codereview.chromium.org/638353002/diff/130001/cc/resources/picture_la...
cc/resources/picture_layer_tiling.cc:470: // Recycled twin does not also have a
recycled twin, so pass nullptr.
just use null

https://codereview.chromium.org/638353002/diff/130001/cc/resources/picture_la...
File cc/resources/picture_layer_tiling.h (right):

https://codereview.chromium.org/638353002/diff/130001/cc/resources/picture_la...
cc/resources/picture_layer_tiling.h:336: TileMap tiles_;  // It is not legal to
have a nullptr tile in the tiles_ map.
just use null in comments like this

https://codereview.chromium.org/638353002/diff/130001/cc/resources/picture_pi...
File cc/resources/picture_pile_impl.h (right):

https://codereview.chromium.org/638353002/diff/130001/cc/resources/picture_pi...
cc/resources/picture_pile_impl.h:32: // rasterizing to the stats if the
respective pointer is not nullptr. When
just use null

https://codereview.chromium.org/638353002/diff/130001/cc/resources/resource_p...
File cc/resources/resource_provider.h (right):

https://codereview.chromium.org/638353002/diff/130001/cc/resources/resource_p...
cc/resources/resource_provider.h:528: // Returns nullptr if the output_surface_
does not have a ContextProvider.
just use null

https://codereview.chromium.org/638353002/diff/130001/cc/resources/single_rel...
File cc/resources/single_release_callback.cc (right):

https://codereview.chromium.org/638353002/diff/130001/cc/resources/single_rel...
cc/resources/single_release_callback.cc:15: << "Use a nullptr
SingleReleaseCallback for an empty callback.";
just use null

https://codereview.chromium.org/638353002/diff/130001/cc/resources/single_rel...
File cc/resources/single_release_callback_impl.cc (right):

https://codereview.chromium.org/638353002/diff/130001/cc/resources/single_rel...
cc/resources/single_release_callback_impl.cc:17: << "Use a nullptr
SingleReleaseCallbackImpl for an empty callback.";
just use null

https://codereview.chromium.org/638353002/diff/130001/cc/resources/texture_up...
File cc/resources/texture_uploader_unittest.cc (right):

https://codereview.chromium.org/638353002/diff/130001/cc/resources/texture_up...
cc/resources/texture_uploader_unittest.cc:118: // If nullptr, we aren't checking
texture contents.
just use null

[Avi (use Gerrit), 2014-10-10 21:17:10]

Peter wrote up a guideline as to doing these kinds of changes:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/As26W6SbxQU

[Avi (use Gerrit), 2014-10-24 21:08:40]

avi@chromium.org changed reviewers:
+ avi@chromium.org