Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 638333002: Take two at fixing duplicate alert failures. (Closed)

Created:
6 years, 2 months ago by ojan
Modified:
6 years, 2 months ago
CC:
leviw_travelin_and_unemployed, blink-reviews, cbiesinger, dsinclair, jochen (gone - plz use gerrit), michaelpg, ojan, szager1, teravest
Project:
blink
Visibility:
Public.

Description

Take two at fixing duplicate alert failures. r183289 caused a new overwriting alerts bug because it didn't replicate the way builder_alerts handled null failure reasons. Using step::reason won't actually be unique if the reason is null since builder_alerts doesn't merge failures with null reasons. R=leviw@chromium.org,jyasskin@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -7 lines) Patch
M Tools/GardeningServer/model/ct-step-failure.html View 1 chunk +12 lines, -1 line 0 comments Download
M Tools/GardeningServer/model/test/ct-failures-tests.html View 4 chunks +56 lines, -3 lines 0 comments Download
M Tools/GardeningServer/model/test/ct-step-failure-tests.html View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ojan
6 years, 2 months ago (2014-10-09 07:01:20 UTC) #1
ojan
ping
6 years, 2 months ago (2014-10-10 02:50:36 UTC) #2
ojan
REVIEW MAH PATCHZ NOW UR ELSE
6 years, 2 months ago (2014-10-16 04:14:10 UTC) #3
leviw_travelin_and_unemployed
Okay dokay LGTM. _ _______ _______ _______ (_) (_______|_______|_______) _ _ ___ _ _ _ ...
6 years, 2 months ago (2014-10-16 17:33:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638333002/1
6 years, 2 months ago (2014-10-16 17:34:01 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 17:35:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183831

Powered by Google App Engine
This is Rietveld 408576698