Take two at fixing duplicate alert failures.

Tools/GardeningServer/model/test/ct-failures-tests.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="../ct-failures.html">
 
 <link rel="import" href="../../lib/network-simulator.html">
 <link rel="import" href="../ct-commit-list.html">
@@ skipping 252 matching lines @@
                 v8: 50,
                 chromium: 200,
               },
               merged_last_passing: {
                 blink: 50,
                 nacl: 50,
                 v8: 50,
                 chromium: 199,
               },
             },
+            {
+              sort_key: 'mac: Mac Tests',
+              failure_keys: [ 'f3', ],
+              likely_revisions: [
+                'chromium: 100',
+                'chromium: 101',
+              ],
+              merged_first_failing: {
+                blink: 50,
+                nacl: 50,
+                v8: 50,
+                chromium: 200,
+              },
+              merged_last_passing: {
+                blink: 50,
+                nacl: 50,
+                v8: 50,
+                chromium: 199,
+              },
+            },
           ],
           alerts: [
             {
               last_result_time: 1409697347.089103,
               passing_build: 2485,
               last_failing_build: 2489,
               failing_build: 2486,
               latest_revisions: {
                 v8: 50,
                 chromium: 103,
@@ skipping 44 matching lines @@
               step_name: "foo_tests",
               tree: 'chromium',
               passing_revisions: {
                 v8: 50,
                 chromium: 99,
                 nacl: 50,
                 blink: 50
               },
               would_close_tree: true
             },
+            {
+              last_result_time: 1409697347.089103,
+              passing_build: 2485,
+              last_failing_build: 2489,
+              failing_build: 2486,
+              latest_revisions: {
+                v8: 50,
+                chromium: 103,
+                nacl: 50,
+                blink: 51
+              },
+              master_url: "https://build.chromium.org/p/chromium.mac",
+              reason: null,
+              failing_revisions: {
+                v8: 50,
+                chromium: 101,
+                nacl: 50,
+                blink: 50
+              },
+              builder_name: "Mac Tests",
+              key: "f3",
+              step_name: "compile",
+              tree: 'chromium',
+              passing_revisions: {
+                v8: 50,
+                chromium: 99,
+                nacl: 50,
+                blink: 50
+              },
+              would_close_tree: true
+            },
           ],
           date: 1409697816.726562,
         },
         'trooper-o-matic.appspot.com/alerts': {
 
         }
       }
       simulator.json = function(url) {
         var matched = Object.find(netData, function(key) {
           return url.indexOf(key) != -1;
         });
         if (matched) {
           return Promise.resolve(netData[matched]);
         } else {
           return Promise.reject('Unexpected url: ' + url);
         }
       };
       simulator.runTest(function() {
         var analyzer = new CTFailures(CTCommitLogMock());
         return analyzer.update().then(function() {
           assert.property(analyzer.failures, 'chromium');
-          assert.lengthOf(analyzer.failures.chromium, 3);
+          assert.lengthOf(analyzer.failures.chromium, 4);
           var masterFailureGroup = analyzer.failures.chromium[0];
           var testFailureGroup = analyzer.failures.chromium[1];
           var compileFailureGroup = analyzer.failures.chromium[2];
+          var macCompileFailureGroup = analyzer.failures.chromium[3];
           assert.equal(compileFailureGroup.constructor, CTFailureGroup);
-          assert.equal(compileFailureGroup.key, 'compile::null');
+          assert.equal(compileFailureGroup.key, 'compile::Linux Tests (dbg)(1)');
           assert.lengthOf(compileFailureGroup.data.failures, 1);
           var failure = compileFailureGroup.data.failures[0];
           assert.equal(failure.constructor, CTStepFailure);
-          assert.equal(failure.key, 'compile::null');
+          assert.equal(failure.key, 'compile::Linux Tests (dbg)(1)');
           assert.equal(failure.step, 'compile');
           assert.equal(failure.testName, null);
           var resultNodesByBuilder = failure.resultNodesByBuilder;
           assert.property(resultNodesByBuilder, 'Linux Tests (dbg)(1)');
           var dbgBuilder = resultNodesByBuilder['Linux Tests (dbg)(1)'];
           assert.propertyVal(dbgBuilder, 'actual', 'UNKNOWN');
           assert.propertyVal(dbgBuilder, 'lastFailingBuild', 2489);
           assert.propertyVal(dbgBuilder, 'masterUrl', 'https://build.chromium.org/p/chromium.linux');
           assert.propertyVal(dbgBuilder, 'failingBuildCount', 4);
           assert.property(analyzer.failures, 'blink');
@@ skipping 10 matching lines @@
           // Flip |expanded| to true to check that it's preserved across updates.
           repositoryCommitList.expanded = true;
 
           // Update |netData| to make sure it's propagated into the updated values.
           netData['sheriff-o-matic.appspot.com/alerts'].alerts[0].last_failing_build = 2490;
 
           return analyzer.update().then(function() {
             assert.strictEqual(analyzer.failures.chromium[0], masterFailureGroup)
             assert.strictEqual(analyzer.failures.chromium[1], testFailureGroup)
             assert.strictEqual(analyzer.failures.chromium[2], compileFailureGroup)
+            assert.strictEqual(analyzer.failures.chromium[3], macCompileFailureGroup)
             assert.strictEqual(compileFailureGroup.data.failures[0], failure)
             assert.strictEqual(failure.resultNodesByBuilder, resultNodesByBuilder);
             assert.strictEqual(resultNodesByBuilder['Linux Tests (dbg)(1)'], dbgBuilder);
             assert.propertyVal(dbgBuilder, 'lastFailingBuild', 2490);
 
             assert.strictEqual(compileFailureGroup.data.commitList, commitList);
             assert.strictEqual(commitList.repositories[0], repositoryCommitList);
             assert.propertyVal(repositoryCommitList, 'expanded', true);
           });
         });
@@ skipping 45 matching lines @@
       analyzer._processFailuresForRangeGroup(newFailures, range_groups, alertsByKey, annotations)
       assert.ok('test-tree' in newFailures)
       assert.notOk('chromium' in newFailures)
     });
   });
 
 });
 
 })()
 </script>