Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: Tools/GardeningServer/model/ct-step-failure.html

Issue 638333002: Take two at fixing duplicate alert failures. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/GardeningServer/model/test/ct-failures-tests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/model/ct-step-failure.html
diff --git a/Tools/GardeningServer/model/ct-step-failure.html b/Tools/GardeningServer/model/ct-step-failure.html
index de5fad4470fc524800ee78aa203ce1c6c0b198f4..25ffb1871b89e6d638b367130f505f97d855c1c6 100644
--- a/Tools/GardeningServer/model/ct-step-failure.html
+++ b/Tools/GardeningServer/model/ct-step-failure.html
@@ -6,7 +6,18 @@ found in the LICENSE file.
<script>
function CTStepFailure(step, reason, resultsByBuilder) {
- this.key = step + '::' + reason;
+ this.key = step + '::'
+
+ // The key needs to be unique, so disambiguate null reason
+ // failures by their builders, but don't do regular failures
+ // by builders because we want failures with reasons to update
+ // the existing failure group instead of causing the group to
+ // get recreated since throwing it away loses in app state.
+ if (reason)
+ this.key += reason;
+ else
+ this.key += Object.keys(resultsByBuilder).join('::');
+
this.step = step;
// FIXME: Rename this to reason.
this.testName = reason;
« no previous file with comments | « no previous file | Tools/GardeningServer/model/test/ct-failures-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698