Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 638313002: Web Animations: Overhaul and trace play state in AnimationPlayer (Closed)

Created:
6 years, 2 months ago by dstockwell
Modified:
6 years, 2 months ago
Reviewers:
shans
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Project:
blink
Visibility:
Public.

Description

Web Animations: Overhaul and trace play state in AnimationPlayer Adds an update scope and instruments call sites which require an up-to-date current time or modify the play state. Tracing now displays spans for the pending and running phases. BUG=351446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183780

Patch Set 1 #

Patch Set 2 : Remove unused code. #

Patch Set 3 : Remove stray printf. #

Total comments: 6

Patch Set 4 : Move setCompositorPending to update scope. #

Patch Set 5 : Don't set pending when notifying a main-thread start time. #

Patch Set 6 : Don't set compositor pending when paused for testing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -97 lines) Patch
M Source/core/animation/AnimationPlayer.h View 1 2 3 4 4 chunks +34 lines, -12 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 2 3 4 5 28 chunks +152 lines, -73 lines 0 comments Download
M Source/core/animation/AnimationPlayerTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/AnimationStackTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationTimelineTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/CompositorPendingAnimations.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/CompositorPendingAnimations.cpp View 1 2 3 4 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dstockwell
6 years, 2 months ago (2014-10-09 06:55:48 UTC) #2
shans
lgtm https://codereview.chromium.org/638313002/diff/40001/Source/core/animation/AnimationPlayer.cpp File Source/core/animation/AnimationPlayer.cpp (right): https://codereview.chromium.org/638313002/diff/40001/Source/core/animation/AnimationPlayer.cpp#newcode198 Source/core/animation/AnimationPlayer.cpp:198: #if ENABLE(ASSERT) is ASSERT stronger than DEBUG? https://codereview.chromium.org/638313002/diff/40001/Source/core/animation/AnimationPlayer.cpp#newcode745 ...
6 years, 2 months ago (2014-10-15 03:38:01 UTC) #3
dstockwell
https://codereview.chromium.org/638313002/diff/40001/Source/core/animation/AnimationPlayer.cpp File Source/core/animation/AnimationPlayer.cpp (right): https://codereview.chromium.org/638313002/diff/40001/Source/core/animation/AnimationPlayer.cpp#newcode198 Source/core/animation/AnimationPlayer.cpp:198: #if ENABLE(ASSERT) On 2014/10/15 at 03:38:00, shans wrote: > ...
6 years, 2 months ago (2014-10-15 08:30:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638313002/100001
6 years, 2 months ago (2014-10-16 04:15:26 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 04:59:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as 183780

Powered by Google App Engine
This is Rietveld 408576698