Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 637523002: DevTools: use timing information for "disk cached" resources. (Closed)

Created:
6 years, 2 months ago by eustas
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: use timing information for "disk cached" resources. "Disk Cached" resources bring valid timing info, so it should be shown to users. Drive-by: get rid of "cache" property getters/setters. BUG=410413 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183681

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 14 (6 generated)
eustas
6 years, 2 months ago (2014-10-07 11:20:55 UTC) #2
vsevik
lgtm
6 years, 2 months ago (2014-10-14 07:31:18 UTC) #3
vsevik
Can we test this?
6 years, 2 months ago (2014-10-14 07:32:46 UTC) #6
eustas
On 2014/10/14 07:32:46, vsevik wrote: > Can we test this? Done
6 years, 2 months ago (2014-10-14 10:29:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637523002/20001
6 years, 2 months ago (2014-10-14 10:30:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31669)
6 years, 2 months ago (2014-10-14 12:29:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637523002/20001
6 years, 2 months ago (2014-10-14 13:48:01 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 17:04:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183681

Powered by Google App Engine
This is Rietveld 408576698