Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 637523002: DevTools: use timing information for "disk cached" resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index b74e9678710ee0d2b30cfed4f8c3a615ec366324..95b979925816ca83a994880b233a07c157018340 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -2408,7 +2408,7 @@ WebInspector.NetworkTimeCalculator.prototype = {
if (request.fetchedViaServiceWorker)
tooltip = WebInspector.NetworkTimeCalculator._fromServiceWorkerFormat.format(tooltip);
- else if (request.cached)
+ else if (request.cached())
tooltip = WebInspector.NetworkTimeCalculator._fromCacheFormat.format(tooltip);
return {left: leftLabel, right: rightLabel, tooltip: tooltip};
},
@@ -2702,7 +2702,7 @@ WebInspector.NetworkDataGridNode.prototype = {
this._barAreaElement.request = this._request;
var type = this._request.type.name();
- var cached = this._request.cached;
+ var cached = this._request.cached();
this._barLeftElement = this._barAreaElement.createChild("div", "network-graph-bar");
this._barLeftElement.classList.add(type, "waiting");
@@ -2759,7 +2759,7 @@ WebInspector.NetworkDataGridNode.prototype = {
*/
_renderStatusCell: function(cell)
{
- cell.classList.toggle("network-dim-cell", !this._isFailed() && (this._request.cached || !this._request.statusCode));
+ cell.classList.toggle("network-dim-cell", !this._isFailed() && (this._request.cached() || !this._request.statusCode));
if (this._request.failed && !this._request.canceled) {
var failText = WebInspector.UIString("(failed)");
@@ -2834,7 +2834,7 @@ WebInspector.NetworkDataGridNode.prototype = {
if (this._request.fetchedViaServiceWorker) {
cell.setTextAndTitle(WebInspector.UIString("(from ServiceWorker)"));
cell.classList.add("network-dim-cell");
- } else if (this._request.cached) {
+ } else if (this._request.cached()) {
cell.setTextAndTitle(WebInspector.UIString("(from cache)"));
cell.classList.add("network-dim-cell");
} else {
@@ -3019,9 +3019,9 @@ WebInspector.NetworkDataGridNode.RemoteAddressComparator = function(a, b)
*/
WebInspector.NetworkDataGridNode.SizeComparator = function(a, b)
{
- if (b._request.cached && !a._request.cached)
+ if (b._request.cached() && !a._request.cached())
return 1;
- if (a._request.cached && !b._request.cached)
+ if (a._request.cached() && !b._request.cached())
return -1;
return (a._request.transferSize - b._request.transferSize) || a._request.indentityCompare(b._request);
}
« no previous file with comments | « Source/devtools/front_end/network/HAREntry.js ('k') | Source/devtools/front_end/network/RequestHeadersView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698