Source/devtools/front_end/audits/AuditRules.js - Issue 637523002: DevTools: use timing information for "disk cached" resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/audits/AuditRules.js

Issue 637523002: DevTools: use timing information for "disk cached" resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/network/resources/cached-script.php ('k') | Source/devtools/front_end/network/HAREntry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/audits/AuditRules.js

diff --git a/Source/devtools/front_end/audits/AuditRules.js b/Source/devtools/front_end/audits/AuditRules.js

index aa61a24f2b61c8926eeb09e31abc9e09596050b6..c2aa0cc05b63b5cafa432bc63ab71fe4bb10b314 100644

--- a/Source/devtools/front_end/audits/AuditRules.js

+++ b/Source/devtools/front_end/audits/AuditRules.js

@@ -94,7 +94,7 @@ WebInspector.AuditRules.GzipRule.prototype = {

var summary = result.addChild("", true);

for (var i = 0, length = requests.length; i < length; ++i) {

var request = requests[i];

- if (request.cached || request.statusCode === 304)

+ if (request.cached() || request.statusCode === 304)

continue; // Do not test cached resources.

if (this._shouldCompress(request)) {

var size = request.resourceSize;