Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 637193002: X87: [turbofan] support all shift operands on ia32 (Closed)

Created:
6 years, 2 months ago by chunyang.dai
Modified:
6 years, 2 months ago
Reviewers:
Weiliang, dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] support all shift operands on ia32 port r24387. original commit message: [turbofan] support all shift operands on ia32 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M src/x87/assembler-x87.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/cctest/test-disasm-x87.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
chunyang.dai
weiliang. PTAL. thanks
6 years, 2 months ago (2014-10-08 05:36:42 UTC) #2
Weiliang
lgtm
6 years, 2 months ago (2014-10-08 06:12:55 UTC) #3
Weiliang
6 years, 2 months ago (2014-10-08 06:18:10 UTC) #4
Committed as r24448

Powered by Google App Engine
This is Rietveld 408576698