content/browser/renderer_host/render_widget_host_view_base.h - Issue 637083002: Sets the default background color of inline signin and user manager to grey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 637083002: Sets the default background color of inline signin and user manager to grey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits fixed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/renderer_host/render_widget_host_view_base.cc » ('j') | content/public/browser/render_widget_host_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.h

diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h

index 9e4a0092fae17dbb8618cd16afe3b1287c59d957..adf890497cb0d75c1a5046ef51067a316626ad7f 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.h

+++ b/content/browser/renderer_host/render_widget_host_view_base.h

@@ -70,8 +70,9 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,

virtual ~RenderWidgetHostViewBase();

// RenderWidgetHostView implementation.

- virtual void SetBackgroundOpaque(bool opaque) override;

- virtual bool GetBackgroundOpaque() override;

+ virtual void SetBackgroundColor(SkColor color) override;

+ virtual void FillBackgroundWithDefaultColor() final override;

+ virtual bool GetBackgroundOpaque() final override;

virtual ui::TextInputClient* GetTextInputClient() override;

virtual bool IsShowingContextMenu() const override;

virtual void SetShowingContextMenu(bool showing_menu) override;

@@ -379,8 +380,8 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,

// autofill...).

blink::WebPopupType popup_type_;

- // When false, the background of the web content is not fully opaque.

- bool background_opaque_;

+ // The background color of the web content.

+ SkColor background_color_;

// While the mouse is locked, the cursor is hidden from the user. Mouse events

// are still generated. However, the position they report is the last known