content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 637083002: Sets the default background color of inline signin and user manager to grey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 637083002: Sets the default background color of inline signin and user manager to grey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits fixed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.h ('k') | content/browser/renderer_host/render_widget_host_view_base.h » ('j') | content/public/browser/render_widget_host_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index 95c44a36eab102bade3fca9e181afd677755d6fc..a1419c2fa3433bc8cb126386419965641363d846 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -802,8 +802,9 @@ gfx::Rect RenderWidgetHostViewAura::GetViewBounds() const {

return window_->GetBoundsInScreen();

}

-void RenderWidgetHostViewAura::SetBackgroundOpaque(bool opaque) {

- RenderWidgetHostViewBase::SetBackgroundOpaque(opaque);

+void RenderWidgetHostViewAura::SetBackgroundColor(SkColor color) {

+ RenderWidgetHostViewBase::SetBackgroundColor(color);

+ bool opaque = GetBackgroundOpaque();

host_->SetBackgroundOpaque(opaque);

window_->layer()->SetFillsBoundsOpaquely(opaque);

}

@@ -1687,7 +1688,7 @@ void RenderWidgetHostViewAura::OnPaint(gfx::Canvas* canvas) {

// canvas coming from the compositor to already be initialized as

// transparent.

if (window_->layer()->fills_bounds_opaquely())

- canvas->DrawColor(SK_ColorWHITE);

+ canvas->DrawColor(background_color_);

}

void RenderWidgetHostViewAura::OnDeviceScaleFactorChanged(