content/public/browser/render_widget_host_view.h - Issue 637083002: Sets the default background color of inline signin and user manager to grey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/render_widget_host_view.h

Issue 637083002: Sets the default background color of inline signin and user manager to grey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits fixed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/render_widget_host_view.h

diff --git a/content/public/browser/render_widget_host_view.h b/content/public/browser/render_widget_host_view.h

index 9fe797c755f1d0cc2002b0fdd87f99c3e636efc3..f69a55ab1320dcbe06ec5ea05af38506677ca548 100644

--- a/content/public/browser/render_widget_host_view.h

+++ b/content/public/browser/render_widget_host_view.h

@@ -10,6 +10,7 @@

#include "base/strings/string16.h"

#include "content/common/content_export.h"

#include "third_party/skia/include/core/SkBitmap.h"

+#include "third_party/skia/include/core/SkColor.h"

#include "third_party/skia/include/core/SkRegion.h"

#include "third_party/WebKit/public/web/WebInputEvent.h"

#include "ui/gfx/native_widget_types.h"

@@ -104,9 +105,12 @@ class CONTENT_EXPORT RenderWidgetHostView {

// Returns the currently selected text.

virtual base::string16 GetSelectedText() const = 0;

- // Subclasses should override this method to do what is appropriate to set

- // the background to be transparent or opaque.

- virtual void SetBackgroundOpaque(bool opaque) = 0;

+ // Subclasses should override this method to set the background color. |color|

+ // could be transparent or opaque.

+ virtual void SetBackgroundColor(SkColor color) = 0;

+ // Convenience method to fill the background layer with the default color by

+ // calling |SetBackgroundColor|.

+ virtual void FillBackgroundWithDefaultColor() = 0;

sky 2014/10/10 02:17:33 FillBackground sounds immediate. I would go with S

guohui 2014/10/10 17:20:17 Done.

virtual bool GetBackgroundOpaque() = 0;

// Return value indicates whether the mouse is locked successfully or not.