Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 636363002: Splits window manager like methods into ViewManagerServiceDelegate (Closed)

Created:
6 years, 2 months ago by sky
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Splits window manager like methods into ViewManagerServiceDelegate When connecting to the root the ViewManager also connects to the ViewManagerServiceDelegate. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/38b5f50b180ed985b84ec0d4f02c84a389a24bea Cr-Commit-Position: refs/heads/master@{#299544}

Patch Set 1 #

Patch Set 2 : minor cleanup #

Total comments: 3

Patch Set 3 : Fix gyp #

Patch Set 4 : rename to windowmanager #

Patch Set 5 : cleanup #

Total comments: 2

Patch Set 6 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -347 lines) Patch
M mojo/examples/window_manager/window_manager.cc View 1 2 3 3 chunks +4 lines, -28 lines 0 comments Download
M mojo/examples/wm_flow/wm/wm.cc View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 4 5 5 chunks +9 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 2 3 3 chunks +0 lines, -8 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 2 3 4 chunks +1 line, -30 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 2 chunks +0 lines, -12 lines 0 comments Download
D mojo/services/public/cpp/view_manager/window_manager_delegate.h View 1 chunk +0 lines, -33 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 2 chunks +0 lines, -17 lines 0 comments Download
A + mojo/services/public/interfaces/window_manager/BUILD.gn View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A mojo/services/public/interfaces/window_manager/window_manager.mojom View 1 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/services/view_manager/connection_manager.h View 1 2 3 4 chunks +14 lines, -9 lines 0 comments Download
M mojo/services/view_manager/connection_manager.cc View 1 2 3 4 4 chunks +18 lines, -14 lines 0 comments Download
M mojo/services/view_manager/display_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_init_service_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 1 2 3 2 chunks +2 lines, -25 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 2 3 4 10 chunks +64 lines, -19 lines 0 comments Download
A mojo/services/view_manager/window_manager_client_impl.h View 1 2 3 4 1 chunk +55 lines, -0 lines 0 comments Download
A mojo/services/view_manager/window_manager_client_impl.cc View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 1 2 3 4 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/services/window_manager/main.cc View 3 chunks +1 line, -3 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 1 2 3 8 chunks +22 lines, -15 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 1 2 3 4 6 chunks +17 lines, -24 lines 0 comments Download
A mojo/services/window_manager/window_manager_delegate.h View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A + mojo/services/window_manager/window_manager_service2_impl.h View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
A + mojo/services/window_manager/window_manager_service2_impl.cc View 1 2 3 4 4 chunks +15 lines, -15 lines 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.h View 1 2 3 1 chunk +14 lines, -21 lines 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.cc View 1 2 3 1 chunk +14 lines, -57 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
sky
6 years, 2 months ago (2014-10-08 23:37:39 UTC) #1
Ben Goodger (Google)
https://codereview.chromium.org/636363002/diff/20001/mojo/services/public/interfaces/view_manager/view_manager_service_delegate.mojom File mojo/services/public/interfaces/view_manager/view_manager_service_delegate.mojom (right): https://codereview.chromium.org/636363002/diff/20001/mojo/services/public/interfaces/view_manager/view_manager_service_delegate.mojom#newcode11 mojo/services/public/interfaces/view_manager/view_manager_service_delegate.mojom:11: [Client=ViewManagerServiceDelegateClient] I think these are probably better called something ...
6 years, 2 months ago (2014-10-09 17:11:40 UTC) #2
sky
I've renamed the types to WindowManagerService and WindowManagerClient.
6 years, 2 months ago (2014-10-10 22:57:06 UTC) #3
Ben Goodger (Google)
lgtm https://codereview.chromium.org/636363002/diff/390001/mojo/services/public/interfaces/window_manager/window_manager.mojom File mojo/services/public/interfaces/window_manager/window_manager.mojom (right): https://codereview.chromium.org/636363002/diff/390001/mojo/services/public/interfaces/window_manager/window_manager.mojom#newcode10 mojo/services/public/interfaces/window_manager/window_manager.mojom:10: [Client=WindowManagerClient] // Document the roles of these interfaces ...
6 years, 2 months ago (2014-10-14 16:44:37 UTC) #4
sky
https://codereview.chromium.org/636363002/diff/390001/mojo/services/public/interfaces/window_manager/window_manager.mojom File mojo/services/public/interfaces/window_manager/window_manager.mojom (right): https://codereview.chromium.org/636363002/diff/390001/mojo/services/public/interfaces/window_manager/window_manager.mojom#newcode10 mojo/services/public/interfaces/window_manager/window_manager.mojom:10: [Client=WindowManagerClient] On 2014/10/14 16:44:37, Ben Goodger (Google) wrote: > ...
6 years, 2 months ago (2014-10-14 19:21:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636363002/480001
6 years, 2 months ago (2014-10-14 19:23:27 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:480001)
6 years, 2 months ago (2014-10-14 20:58:10 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 21:50:51 UTC) #9
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/38b5f50b180ed985b84ec0d4f02c84a389a24bea
Cr-Commit-Position: refs/heads/master@{#299544}

Powered by Google App Engine
This is Rietveld 408576698