Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 636363002: Splits window manager like methods into ViewManagerServiceDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge 2 trunk Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/view_manager/view_manager.mojom
diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom
index 094f5d3d3829d762d9bbc819cdee45c5b87f139c..bf8b82f7e945471f5ea792e0063ac838726b4d60 100644
--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom
+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom
@@ -137,11 +137,6 @@ interface ViewManagerService {
Embed(string url,
uint32 view_id,
ServiceProvider? service_provider) => (bool success);
-
- // TODO(sky): move these to a separate interface when FIFO works.
-
- // Sends OnViewInputEvent() to the owner of the specified view.
- DispatchOnViewInputEvent(uint32 view_id, mojo.Event event);
};
// Changes to views are not sent to the connection that originated the
@@ -197,18 +192,6 @@ interface ViewManagerClient {
// Invoked when an event is targeted at the specified view.
OnViewInputEvent(uint32 view, mojo.Event event) => ();
-
- // TODO(sky): The following methods represent an interface between the view
- // manager and the application embedded at the service root view
- // (i.e. the window manager). These methods are not called on
- // any other clients. They should be moved to a separate interface
- // once support for derived FIFOs is landed.
-
- // Requests the window manager create a "top level" view embedding |url|.
- Embed(string url, ServiceProvider&? service_provider);
-
- // Requests the view manager dispatch the event.
- DispatchOnViewInputEvent(mojo.Event event);
};
}

Powered by Google App Engine
This is Rietveld 408576698