Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 635693003: [ServiceWorker] Add WebDataSource argument to isControlledByServiceWorker() [3/3 blink]. (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
michaeln, tkent, Mike West
CC:
blink-reviews, jamesr, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add WebDataSource argument to isControlledByServiceWorker() [3/3 blink] In current implementation, while the new page is loading the request from the existing previous page may refer to the provisional dataSource in isControlledByServiceWorker(). But this is wrong. We should pass WebDataSource to this method to avoid the ambiguity. 1/3 blink: https://codereview.chromium.org/634813002 2/3 chromium: https://codereview.chromium.org/629953003 3/3 blink: https://codereview.chromium.org/635693003 BUG=411151 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183436

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M public/web/WebFrameClient.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
horo
michaeln@ Could you please review this?
6 years, 2 months ago (2014-10-07 02:22:26 UTC) #2
Mike West
And, assuming the first two land, this obviously LGTM as well. As an aside, I ...
6 years, 2 months ago (2014-10-07 15:45:58 UTC) #4
michaeln
lgtm, but you'll need a public api owner
6 years, 2 months ago (2014-10-07 19:32:21 UTC) #5
horo
tkent@ Could you please review this cl? Thank you!
6 years, 2 months ago (2014-10-07 22:50:55 UTC) #7
tkent
lgtm
6 years, 2 months ago (2014-10-08 03:09:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635693003/40001
6 years, 2 months ago (2014-10-08 22:31:59 UTC) #10
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-09 03:24:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635693003/40001
6 years, 2 months ago (2014-10-09 03:26:37 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 06:31:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183436

Powered by Google App Engine
This is Rietveld 408576698