[ServiceWorker] Add WebDataSource argument to isControlledByServiceWorker() [2/3 chromium]

[ServiceWorker] Add WebDataSource argument to isControlledByServiceWorker() [2/3 chromium].

In current implementation, while the new page is loading the request from the existing previous page may refer to the provisional dataSource in isControlledByServiceWorker().
But this is wrong.
We should pass WebDataSource to this method to avoid the ambiguity.

1/3 blink: https://codereview.chromium.org/634813002
2/3 chromium: https://codereview.chromium.org/629953003
3/3 blink: https://codereview.chromium.org/635693003

BUG=411151
Committed: https://crrev.com/2945dc9627894bf5d366c16a02d77a5d75ebe7ca
Cr-Commit-Position: refs/heads/master@{#298732}

[horo, 2014-10-07 02:03:05]

horo@chromium.org changed reviewers:
+ michaeln@chromium.org

[horo, 2014-10-07 02:03:06]

michaeln@
Could you please review this?

[Mike West, 2014-10-07 15:44:30]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2014-10-07 15:44:31]

Drive-by LGTM here as well. This is significantly better than the previous patch
I took a look at. Thanks for taking another pass!

[michaeln, 2014-10-07 19:31:32]

lgtm 2

[horo, 2014-10-07 22:50:00]

horo@chromium.org changed reviewers:
+ jochen@chromium.org

[horo, 2014-10-07 22:50:00]

jochen@
Could you please review this?

[jochen (gone - plz use gerrit), 2014-10-08 14:52:13]

lgtm

for future reference, it would be nicer to keep the API working while
refactoring, i.e. you could have first added the new implementation in chrome
and make the old call just forward to the new call, and then switch blink over,
and then remove the old implementation in chrome.

[horo, 2014-10-08 15:39:17]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-10-08 15:40:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/629953003/20001

[horo, 2014-10-08 15:40:56]

On 2014/10/08 14:52:13, jochen wrote:
> lgtm
> 
> for future reference, it would be nicer to keep the API working while
> refactoring, i.e. you could have first added the new implementation in chrome
> and make the old call just forward to the new call, and then switch blink
over,
> and then remove the old implementation in chrome.

Thank you.
But I think it is ok for this method because there is no caller yet.

[commit-bot: I haz the power, 2014-10-08 16:47:22]

Committed patchset #2 (id:20001) as 937216718b42b325803a321145620bc9a5a258e5

[commit-bot: I haz the power, 2014-10-08 16:48:27]

Patchset 2 (id:??) landed as
https://crrev.com/2945dc9627894bf5d366c16a02d77a5d75ebe7ca
Cr-Commit-Position: refs/heads/master@{#298732}