Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: chrome/common/chrome_version_info.h

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: linux include Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_content_client_ios.mm ('k') | chrome/common/chrome_version_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_version_info.h
diff --git a/chrome/common/chrome_version_info.h b/chrome/common/chrome_version_info.h
index 3ebe6fce5d011254ee902555afedbe08b51c46b4..4f3d3be4a2013861e0854724ef00e0c52bafb945 100644
--- a/chrome/common/chrome_version_info.h
+++ b/chrome/common/chrome_version_info.h
@@ -30,12 +30,6 @@ class VersionInfo {
VersionInfo();
~VersionInfo();
- // In the rare case where we fail to get the version info,
- // is_valid() will return false. The other functions will return
- // the empty string in this case, so it's not harmful if you don't
- // check is_valid().
- bool is_valid() const;
-
// E.g. "Chrome/a.b.c.d"
std::string ProductNameAndVersionForUserAgent() const;
« no previous file with comments | « chrome/common/chrome_content_client_ios.mm ('k') | chrome/common/chrome_version_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698