Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 63343004: Remove DialogDelegate::UseNewStyle and unused code. (Closed)

Created:
7 years, 1 month ago by msw
Modified:
7 years, 1 month ago
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, benquan, Ilya Sherman, dyu1, chromium-apps-reviews_chromium.org, dkrahn+watch_chromium.org, benjhayden+dwatch_chromium.org, Dane Wallinga, oshima+watch_chromium.org, tfarina, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, ben+views_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Mike Wittman
Visibility:
Public.

Description

Remove DialogDelegate::UseNewStyle and unused code. Remove DialogDelegate::UseNewStyle; (true since r235220). (update callsites to assume the new style should be used) Rename CreateNewStyleFrameView -> CreateDialogFrameView. Remove TabbedPane's draw_border ctor arg (always false). Remove ConstrainedWindowFrameView and helper classes. Remove constrained_*_vista.png and IDR_CONSTRAINED_*_V. Update Widget::CreateWindowAsFramelessChild callsites. (remove old |parent| arg, web_contents_view.h includes) BUG=319038, 170193, 166075 TEST=No UI changes, no build breaks, just less code. R=sky@chromium.org,oshima@chromium.org,estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235809

Patch Set 1 #

Patch Set 2 : Remove ConstrainedWindowFrameView, helpers, images. #

Patch Set 3 : Additional cleanup; sync and rebase. #

Total comments: 19

Patch Set 4 : Restore [D]CHECKs and loop scoping. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -825 lines) Patch
D chrome/app/theme/default_100_percent/constrained_bottom_center_vista.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_100_percent/constrained_bottom_left_corner_vista.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_100_percent/constrained_bottom_right_corner_vista.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_100_percent/constrained_left_side_vista.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_100_percent/constrained_right_side_vista.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_100_percent/constrained_top_center_vista.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_100_percent/constrained_top_left_corner_vista.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_100_percent/constrained_top_right_corner_vista.png View 1 Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_dialog.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/captive_portal_view.cc View 1 2 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/chromeos/login/captive_portal_window_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/captive_portal_window_proxy.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/captive_portal_window_proxy.cc View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 2 3 9 chunks +15 lines, -37 lines 0 comments Download
M chrome/browser/ui/views/color_chooser_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 2 3 4 chunks +1 line, -17 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 2 7 chunks +14 lines, -522 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 6 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/cookie_info_view.cc View 1 2 5 chunks +11 lines, -38 lines 0 comments Download
M chrome/browser/ui/views/download/download_danger_prompt_views.cc View 1 2 3 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 1 2 4 chunks +1 line, -19 lines 0 comments Download
M chrome/browser/ui/views/importer/import_lock_dialog_view.cc View 1 2 1 chunk +3 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/login_prompt_views.cc View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/pdf_password_dialog.cc View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc View 1 2 3 4 chunks +8 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 1 2 2 chunks +1 line, -8 lines 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/examples/tabbed_pane_example.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/layout/grid_layout.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +3 lines, -9 lines 0 comments Download
M ui/views/widget/widget.cc View 1 2 1 chunk +4 lines, -10 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 2 2 chunks +3 lines, -10 lines 0 comments Download
M ui/views/window/dialog_delegate.h View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 1 2 3 chunks +5 lines, -10 lines 0 comments Download
M ui/views/window/dialog_delegate_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
msw
Please take a look, thanks! sky: c/b/ui/views/*, ui/views/* oshima: c/app/theme/*, c/b/chromeos/* estade: c/b/ui/webui/.../error_screen_handler.cc
7 years, 1 month ago (2013-11-15 21:31:12 UTC) #1
Evan Stade
autofill + webui lgtm
7 years, 1 month ago (2013-11-15 22:00:30 UTC) #2
oshima
c/a/theme, /chromeos/ lgtm
7 years, 1 month ago (2013-11-15 22:23:49 UTC) #3
sky
https://codereview.chromium.org/63343004/diff/240001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (left): https://codereview.chromium.org/63343004/diff/240001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#oldcode1198 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:1198: DCHECK(modal_delegate); How come you removed this? https://codereview.chromium.org/63343004/diff/240001/chrome/browser/ui/views/collected_cookies_views.cc File chrome/browser/ui/views/collected_cookies_views.cc ...
7 years, 1 month ago (2013-11-16 03:03:15 UTC) #4
msw
I restored the DCHECKs and the loop code; please take another look; thanks! https://codereview.chromium.org/63343004/diff/240001/chrome/browser/chromeos/login/captive_portal_window_proxy.cc File ...
7 years, 1 month ago (2013-11-16 04:15:44 UTC) #5
sky
LGTM https://codereview.chromium.org/63343004/diff/240001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (left): https://codereview.chromium.org/63343004/diff/240001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#oldcode1198 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:1198: DCHECK(modal_delegate); On 2013/11/16 04:15:44, msw wrote: > On ...
7 years, 1 month ago (2013-11-18 17:03:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/63343004/350001
7 years, 1 month ago (2013-11-18 17:44:37 UTC) #7
commit-bot: I haz the power
Change committed as 235809
7 years, 1 month ago (2013-11-18 20:43:16 UTC) #8
Mike Wittman
7 years, 1 month ago (2013-11-22 01:28:00 UTC) #9
Message was sent while issue was closed. 
Sorry for the late comment, I've been OOO.

Can you also remove CreateConstrainedStyleNonClientFrameView and all the
CreateNonClientFrameView overrides that use it? If not, the TODOs corresponding
to those overrides should be removed.

Powered by Google App Engine
This is Rietveld 408576698