Remove DialogDelegate::UseNewStyle and unused code.

chrome/browser/ui/views/autofill/autofill_dialog_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 1177 matching lines @@
   UpdateNotificationArea();
   UpdateButtonStripExtraView();
 
   // Ownership of |contents_| is handed off by this call. The widget will take
   // care of deleting itself after calling DeleteDelegate().
   WebContentsModalDialogManager* web_contents_modal_dialog_manager =
       WebContentsModalDialogManager::FromWebContents(
           delegate_->GetWebContents());
   WebContentsModalDialogManagerDelegate* modal_delegate =
       web_contents_modal_dialog_manager->delegate();
-  DCHECK(modal_delegate);

[sky, 2013/11/16 03:03:16]

How come you removed this?

[msw, 2013/11/16 04:15:44]

I removed all these DCHECKs because I thought we typically discouraged DCHECKing
against null pointers immediately before dereferencing them. We crash either way
and it'd only help in this case because it's checked on a distinct line from the
call to CreateWindowAsFramelessChild. Anyway, it's not a big deal, so I restored
them all in response to your concern/inquiry.

[sky, 2013/11/18 17:03:10]

I like DCHECKs like this as a way to document modal_delegate should never be
NULL.

-
   window_ = views::Widget::CreateWindowAsFramelessChild(
-      this,
-      delegate_->GetWebContents()->GetView()->GetNativeView(),
-      modal_delegate->GetWebContentsModalDialogHost()->GetHostView());
+      this, modal_delegate->GetWebContentsModalDialogHost()->GetHostView());
   web_contents_modal_dialog_manager->ShowDialog(window_->GetNativeView());
   focus_manager_ = window_->GetFocusManager();
   focus_manager_->AddFocusChangeListener(this);
 
   ShowDialogInMode(DETAIL_INPUT);
 
   // Listen for size changes on the browser.
   views::Widget* browser_widget =
       views::Widget::GetTopLevelWidgetForNativeView(
           delegate_->GetWebContents()->GetView()->GetNativeView());
@@ skipping 1232 matching lines @@
 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section)
     : section(section),
       container(NULL),
       manual_input(NULL),
       suggested_info(NULL),
       suggested_button(NULL) {}
 
 AutofillDialogViews::DetailsGroup::~DetailsGroup() {}
 
 }  // namespace autofill