Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

Issue 63343004: Remove DialogDelegate::UseNewStyle and unused code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restore [D]CHECKs and loop scoping. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h" 5 #include "chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/ui/views/constrained_window_views.h" 8 #include "chrome/browser/ui/views/constrained_window_views.h"
9 #include "components/web_modal/web_contents_modal_dialog_host.h" 9 #include "components/web_modal/web_contents_modal_dialog_host.h"
10 #include "components/web_modal/web_contents_modal_dialog_manager.h" 10 #include "components/web_modal/web_contents_modal_dialog_manager.h"
11 #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h" 11 #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
12 #include "content/public/browser/native_web_keyboard_event.h" 12 #include "content/public/browser/native_web_keyboard_event.h"
13 #include "content/public/browser/web_contents.h" 13 #include "content/public/browser/web_contents.h"
14 #include "content/public/browser/web_contents_view.h"
15 #include "ui/gfx/size.h" 14 #include "ui/gfx/size.h"
16 #include "ui/views/controls/webview/unhandled_keyboard_event_handler.h" 15 #include "ui/views/controls/webview/unhandled_keyboard_event_handler.h"
17 #include "ui/views/controls/webview/webview.h" 16 #include "ui/views/controls/webview/webview.h"
18 #include "ui/views/view.h" 17 #include "ui/views/view.h"
19 #include "ui/views/widget/widget.h" 18 #include "ui/views/widget/widget.h"
20 #include "ui/views/widget/widget_delegate.h" 19 #include "ui/views/widget/widget_delegate.h"
21 #include "ui/views/window/dialog_delegate.h" 20 #include "ui/views/window/dialog_delegate.h"
22 #include "ui/web_dialogs/web_dialog_delegate.h" 21 #include "ui/web_dialogs/web_dialog_delegate.h"
23 #include "ui/web_dialogs/web_dialog_ui.h" 22 #include "ui/web_dialogs/web_dialog_ui.h"
24 23
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 public ConstrainedWebDialogDelegate, 83 public ConstrainedWebDialogDelegate,
85 public views::WidgetDelegate { 84 public views::WidgetDelegate {
86 public: 85 public:
87 ConstrainedWebDialogDelegateViewViews( 86 ConstrainedWebDialogDelegateViewViews(
88 content::BrowserContext* browser_context, 87 content::BrowserContext* browser_context,
89 WebDialogDelegate* delegate, 88 WebDialogDelegate* delegate,
90 WebDialogWebContentsDelegate* tab_delegate); 89 WebDialogWebContentsDelegate* tab_delegate);
91 virtual ~ConstrainedWebDialogDelegateViewViews(); 90 virtual ~ConstrainedWebDialogDelegateViewViews();
92 91
93 // ConstrainedWebDialogDelegate interface 92 // ConstrainedWebDialogDelegate interface
94 virtual const WebDialogDelegate* 93 virtual const WebDialogDelegate* GetWebDialogDelegate() const OVERRIDE {
95 GetWebDialogDelegate() const OVERRIDE {
96 return impl_->GetWebDialogDelegate(); 94 return impl_->GetWebDialogDelegate();
97 } 95 }
98 virtual WebDialogDelegate* GetWebDialogDelegate() OVERRIDE { 96 virtual WebDialogDelegate* GetWebDialogDelegate() OVERRIDE {
99 return impl_->GetWebDialogDelegate(); 97 return impl_->GetWebDialogDelegate();
100 } 98 }
101 virtual void OnDialogCloseFromWebUI() OVERRIDE { 99 virtual void OnDialogCloseFromWebUI() OVERRIDE {
102 return impl_->OnDialogCloseFromWebUI(); 100 return impl_->OnDialogCloseFromWebUI();
103 } 101 }
104 virtual void ReleaseWebContentsOnDialogClose() OVERRIDE { 102 virtual void ReleaseWebContentsOnDialogClose() OVERRIDE {
105 return impl_->ReleaseWebContentsOnDialogClose(); 103 return impl_->ReleaseWebContentsOnDialogClose();
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 } 144 }
147 145
148 virtual ui::ModalType GetModalType() const OVERRIDE { 146 virtual ui::ModalType GetModalType() const OVERRIDE {
149 #if defined(USE_ASH) 147 #if defined(USE_ASH)
150 return ui::MODAL_TYPE_CHILD; 148 return ui::MODAL_TYPE_CHILD;
151 #else 149 #else
152 return views::WidgetDelegate::GetModalType(); 150 return views::WidgetDelegate::GetModalType();
153 #endif 151 #endif
154 } 152 }
155 153
156 virtual void OnWidgetMove() OVERRIDE {
157 // We need to check the existence of the widget because when running on
158 // WinXP this could get executed before the widget is entirely created.
159 if (!GetWidget())
160 return;
161
162 if (!views::DialogDelegate::UseNewStyle()) {
163 GetWidget()->CenterWindow(
164 GetWidget()->non_client_view()->GetPreferredSize());
165 }
166 views::WidgetDelegate::OnWidgetMove();
167 }
168
169 // views::WebView overrides. 154 // views::WebView overrides.
170 virtual bool AcceleratorPressed( 155 virtual bool AcceleratorPressed(
171 const ui::Accelerator& accelerator) OVERRIDE { 156 const ui::Accelerator& accelerator) OVERRIDE {
172 // Pressing ESC closes the dialog. 157 // Pressing ESC closes the dialog.
173 DCHECK_EQ(ui::VKEY_ESCAPE, accelerator.key_code()); 158 DCHECK_EQ(ui::VKEY_ESCAPE, accelerator.key_code());
174 impl_->window()->Close(); 159 impl_->window()->Close();
175 return true; 160 return true;
176 } 161 }
177 virtual gfx::Size GetPreferredSize() OVERRIDE { 162 virtual gfx::Size GetPreferredSize() OVERRIDE {
178 gfx::Size size; 163 gfx::Size size;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 ConstrainedWebDialogDelegateViewViews* constrained_delegate = 210 ConstrainedWebDialogDelegateViewViews* constrained_delegate =
226 new ConstrainedWebDialogDelegateViewViews( 211 new ConstrainedWebDialogDelegateViewViews(
227 browser_context, delegate, tab_delegate); 212 browser_context, delegate, tab_delegate);
228 WebContentsModalDialogManager* web_contents_modal_dialog_manager = 213 WebContentsModalDialogManager* web_contents_modal_dialog_manager =
229 WebContentsModalDialogManager::FromWebContents(web_contents); 214 WebContentsModalDialogManager::FromWebContents(web_contents);
230 WebContentsModalDialogManagerDelegate* modal_delegate = 215 WebContentsModalDialogManagerDelegate* modal_delegate =
231 web_contents_modal_dialog_manager->delegate(); 216 web_contents_modal_dialog_manager->delegate();
232 DCHECK(modal_delegate); 217 DCHECK(modal_delegate);
233 views::Widget* window = views::Widget::CreateWindowAsFramelessChild( 218 views::Widget* window = views::Widget::CreateWindowAsFramelessChild(
234 constrained_delegate, 219 constrained_delegate,
235 web_contents->GetView()->GetNativeView(),
236 modal_delegate->GetWebContentsModalDialogHost()->GetHostView()); 220 modal_delegate->GetWebContentsModalDialogHost()->GetHostView());
237 web_contents_modal_dialog_manager->ShowDialog(window->GetNativeView()); 221 web_contents_modal_dialog_manager->ShowDialog(window->GetNativeView());
238 constrained_delegate->SetWindow(window); 222 constrained_delegate->SetWindow(window);
239 return constrained_delegate; 223 return constrained_delegate;
240 } 224 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/color_chooser_aura.cc ('k') | chrome/browser/ui/views/constrained_window_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698