Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 633323003: Fix unresponsive tab closure when a navigation is in progress. (Closed)

Created:
6 years, 2 months ago by Charlie Reis
Modified:
6 years, 2 months ago
Reviewers:
ncarter (slow), nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, ncarter (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix unresponsive tab closure when a navigation is in progress. TBR=nasko@chromium.org BUG=420557 TEST=Close a tab with an infinite unload event, then navigate right away. Committed: https://crrev.com/1e3617abe7bdb3dd2be95a88924859c640e6944b Cr-Commit-Position: refs/heads/master@{#298987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +7 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 2 chunks +42 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Charlie Reis
Nasko, can you take a look? This prevents us from hitting the CHECK I added ...
6 years, 2 months ago (2014-10-09 20:39:41 UTC) #2
ncarter (slow)
lgtm
6 years, 2 months ago (2014-10-09 21:05:11 UTC) #4
Charlie Reis
Thanks! Nasko's OOO today, so I'll TBR him.
6 years, 2 months ago (2014-10-09 21:48:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633323003/1
6 years, 2 months ago (2014-10-09 21:50:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 22:01:34 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 22:02:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e3617abe7bdb3dd2be95a88924859c640e6944b
Cr-Commit-Position: refs/heads/master@{#298987}

Powered by Google App Engine
This is Rietveld 408576698