Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 617273004: Remove stale RFHM check now that unload runs in the background. (Closed)

Created:
6 years, 2 months ago by Charlie Reis
Modified:
6 years, 2 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove stale RFHM check now that unload runs in the background. BUG=402020 TEST=No behavior change. Committed: https://crrev.com/52538dfb0dee9307b87bb688569ec23893a14cab Cr-Commit-Position: refs/heads/master@{#297688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Charlie Reis
Nasko, can you take a look? I think this is dead code, and I'm just ...
6 years, 2 months ago (2014-10-01 17:43:25 UTC) #2
nasko
LGTM
6 years, 2 months ago (2014-10-01 18:06:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617273004/1
6 years, 2 months ago (2014-10-01 18:48:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ba6632f2335001cafd22a563e5575d6682006437
6 years, 2 months ago (2014-10-01 19:21:17 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/52538dfb0dee9307b87bb688569ec23893a14cab Cr-Commit-Position: refs/heads/master@{#297688}
6 years, 2 months ago (2014-10-01 19:21:59 UTC) #7
Charlie Reis
6 years, 2 months ago (2014-10-06 22:39:20 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/632043002/ by creis@chromium.org.

The reason for reverting is: The new CHECK fails if
render_view_host_->is_waiting_for_close_ack_ is true.  See
http://crbug.com/420557..

Powered by Google App Engine
This is Rietveld 408576698