Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 633323003: Fix unresponsive tab closure when a navigation is in progress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 // frame RenderFrameHost. 214 // frame RenderFrameHost.
215 bool is_active() const { return is_active_; } 215 bool is_active() const { return is_active_; }
216 void set_is_active(bool is_active) { is_active_ = is_active; } 216 void set_is_active(bool is_active) { is_active_ = is_active; }
217 217
218 // Tracks whether this RenderViewHost is swapped out, according to its main 218 // Tracks whether this RenderViewHost is swapped out, according to its main
219 // frame RenderFrameHost. 219 // frame RenderFrameHost.
220 void set_is_swapped_out(bool is_swapped_out) { 220 void set_is_swapped_out(bool is_swapped_out) {
221 is_swapped_out_ = is_swapped_out; 221 is_swapped_out_ = is_swapped_out;
222 } 222 }
223 223
224 // TODO(creis): Remove as part of http://crbug.com/418265.
225 bool is_waiting_for_close_ack() const { return is_waiting_for_close_ack_; }
226
224 // Tells the renderer that this RenderView will soon be swapped out, and thus 227 // Tells the renderer that this RenderView will soon be swapped out, and thus
225 // not to create any new modal dialogs until it happens. This must be done 228 // not to create any new modal dialogs until it happens. This must be done
226 // separately so that the PageGroupLoadDeferrers of any current dialogs are no 229 // separately so that the PageGroupLoadDeferrers of any current dialogs are no
227 // longer on the stack when we attempt to swap it out. 230 // longer on the stack when we attempt to swap it out.
228 void SuppressDialogsUntilSwapOut(); 231 void SuppressDialogsUntilSwapOut();
229 232
230 // Close the page ignoring whether it has unload events registers. 233 // Close the page ignoring whether it has unload events registers.
231 // This is called after the beforeunload and unload events have fired 234 // This is called after the beforeunload and unload events have fired
232 // and the user has agreed to continue with closing the page. 235 // and the user has agreed to continue with closing the page.
233 void ClosePageIgnoringUnloadEvents(); 236 void ClosePageIgnoringUnloadEvents();
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 471 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
469 }; 472 };
470 473
471 #if defined(COMPILER_MSVC) 474 #if defined(COMPILER_MSVC)
472 #pragma warning(pop) 475 #pragma warning(pop)
473 #endif 476 #endif
474 477
475 } // namespace content 478 } // namespace content
476 479
477 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 480 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698