Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3143)

Unified Diff: pkg/analysis_server/test/services/completion/local_computer_test.dart

Issue 632323002: local cascade suggestion fix and move towards common tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/services/completion/invocation_computer_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/local_computer_test.dart
diff --git a/pkg/analysis_server/test/services/completion/local_computer_test.dart b/pkg/analysis_server/test/services/completion/local_computer_test.dart
index c504763741993518e3b72e747d971b515c9560fb..90a682dc884be2dc06204e0add8bcdcbc5d727e1 100644
--- a/pkg/analysis_server/test/services/completion/local_computer_test.dart
+++ b/pkg/analysis_server/test/services/completion/local_computer_test.dart
@@ -16,7 +16,7 @@ main() {
}
@ReflectiveTestCase()
-class LocalComputerTest extends AbstractCompletionTest {
+class LocalComputerTest extends AbstractSelectorSuggestionTest {
@override
void setUp() {
@@ -42,16 +42,6 @@ class LocalComputerTest extends AbstractCompletionTest {
assertNotSuggested('b');
}
- test_Block() {
- // Block BlockFunctionBody
- addTestSource('class A {a() {var f; {var x;} ^ var g;}}');
- expect(computeFast(), isTrue);
- assertSuggestClass('A');
- assertSuggestLocalVariable('f', null);
- assertNotSuggested('g');
- assertNotSuggested('x');
- }
-
test_CatchClause_typed() {
// Block CatchClause TryStatement
addTestSource('class A {a() {try{} on E catch (e) {^}}}');
@@ -285,7 +275,6 @@ class LocalComputerTest extends AbstractCompletionTest {
assertNotSuggested('x');
}
- //TODO (danrubel) implement
xtest_ConstructorName_importedClass() {
// SimpleIdentifier PrefixedIdentifier TypeName ConstructorName
// InstanceCreationExpression
@@ -301,7 +290,6 @@ class LocalComputerTest extends AbstractCompletionTest {
});
}
- //TODO (danrubel) implement
xtest_ConstructorName_localClass() {
// SimpleIdentifier PrefixedIdentifier TypeName ConstructorName
// InstanceCreationExpression
@@ -314,7 +302,6 @@ class LocalComputerTest extends AbstractCompletionTest {
});
}
- //TODO (danrubel) implement
xtest_InstanceCreationExpression() {
// SimpleIdentifier TypeName ConstructorName InstanceCreationExpression
addTestSource('class A {a() {var f; {var x;} new ^}} class B { }');
@@ -326,7 +313,6 @@ class LocalComputerTest extends AbstractCompletionTest {
assertNotSuggested('x');
}
- //TODO (danrubel) implement
xtest_IsExpression_imported() {
// SimpleIdentifier TypeName IsExpression IfStatement
addSource('/testB.dart', '''
@@ -340,7 +326,6 @@ class LocalComputerTest extends AbstractCompletionTest {
});
}
- //TODO (danrubel) implement
xtest_IsExpression_local() {
// SimpleIdentifier TypeName IsExpression IfStatement
addTestSource('''
« no previous file with comments | « pkg/analysis_server/test/services/completion/invocation_computer_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698