local cascade suggestion fix and move towards common tests

pkg/analysis_server/test/services/completion/invocation_computer_test.dart

Index: pkg/analysis_server/test/services/completion/invocation_computer_test.dart
diff --git a/pkg/analysis_server/test/services/completion/invocation_computer_test.dart b/pkg/analysis_server/test/services/completion/invocation_computer_test.dart
index 2fb23542b8ade66e88550dde3d843d518e7661b6..0c57891567a7df640ad4fa81611fce89131f0e30 100644
--- a/pkg/analysis_server/test/services/completion/invocation_computer_test.dart
+++ b/pkg/analysis_server/test/services/completion/invocation_computer_test.dart
@@ -18,7 +18,7 @@ main() {
 }
 
 @ReflectiveTestCase()
-class InvocationComputerTest extends AbstractCompletionTest {
+class InvocationComputerTest extends AbstractSelectorSuggestionTest {
 
   @override
   void setUp() {
@@ -26,32 +26,6 @@ class InvocationComputerTest extends AbstractCompletionTest {
     computer = new InvocationComputer();
   }
 
-  test_CascadeExpression_selector1() {
-    // PropertyAccess  CascadeExpression  ExpressionStatement
-    addTestSource('''
-      class A {var b; X _c;}
-      class X{}
-      // looks like a cascade to the parser
-      // but the user is trying to get completions for a non-cascade
-      main() {A a; a.^.b}''');
-    return computeFull(true).then((_) {
-      assertSuggestGetter('b', null);
-      assertSuggestGetter('_c', 'X');
-    });
-  }
-
-  test_CascadeExpression_selector2() {
-    // PropertyAccess  CascadeExpression  ExpressionStatement
-    addTestSource('''
-      class A {var b; X _c;}
-      class X{}
-      main() {A a; a..^b}''');
-    return computeFull().then((_) {
-      assertSuggestGetter('b', null);
-      assertSuggestGetter('_c', 'X');
-    });
-  }
-
   test_CascadeExpression_target() {
     // PropertyAccess  CascadeExpression  ExpressionStatement
     addTestSource('''
@@ -97,6 +71,19 @@ class InvocationComputerTest extends AbstractCompletionTest {
     });
   }
 
+  test_IsExpression() {
+    // SimpleIdentifier  TypeName  IsExpression  IfStatement
+    addSource('/testB.dart', '''
+      lib B;
+      class X {X.c(); X._d(); z() {}}''');
+    addTestSource('''
+      import "/testB.dart";
+      main() {var x; if (x is ^) { }}''');
+    return computeFull().then((_) {
+      assertNoSuggestions();
+    });
+  }
+
   test_PrefixedIdentifier_field() {
     // SimpleIdentifier  PrefixedIdentifier  ExpressionStatement
     addTestSource('''
@@ -275,18 +262,4 @@ class InvocationComputerTest extends AbstractCompletionTest {
       assertNotSuggested('_z');
     });
   }
-
-  //TODO (danrubel) implement
-  xtest_IsExpression() {
-    // SimpleIdentifier  TypeName  IsExpression  IfStatement
-    addSource('/testB.dart', '''
-      lib B;
-      class X {X.c(); X._d(); z() {}}''');
-    addTestSource('''
-      import "/testB.dart";
-      main() {var x; if (x is ^) { }}''');
-    return computeFull().then((_) {
-      assertNoSuggestions();
-    });
-  }
 }