local cascade suggestion fix and move towards common tests

pkg/analysis_server/test/services/completion/local_computer_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.dart.local;
 
 import 'package:analysis_server/src/services/completion/local_computer.dart';
 import 'package:unittest/unittest.dart';
 
 import '../../reflective_tests.dart';
 import 'completion_test_util.dart';
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(LocalComputerTest);
 }
 
 @ReflectiveTestCase()
-class LocalComputerTest extends AbstractCompletionTest {
+class LocalComputerTest extends AbstractSelectorSuggestionTest {
 
   @override
   void setUp() {
     super.setUp();
     computer = new LocalComputer();
   }
 
   test_BinaryExpression_LHS() {
     // SimpleIdentifier  BinaryExpression  VariableDeclaration
     // VariableDeclarationList  VariableDeclarationStatement
     addTestSource('main() {int a = 1, b = ^ + 2;}');
     expect(computeFast(), isTrue);
     assertSuggestLocalVariable('a', 'int');
     assertNotSuggested('b');
   }
 
   test_BinaryExpression_RHS() {
     // SimpleIdentifier  BinaryExpression  VariableDeclaration
     // VariableDeclarationList  VariableDeclarationStatement
     addTestSource('main() {int a = 1, b = 2 + ^;}');
     expect(computeFast(), isTrue);
     assertSuggestLocalVariable('a', 'int');
     assertNotSuggested('b');
   }
 
-  test_Block() {
-    // Block  BlockFunctionBody
-    addTestSource('class A {a() {var f; {var x;} ^ var g;}}');
-    expect(computeFast(), isTrue);
-    assertSuggestClass('A');
-    assertSuggestLocalVariable('f', null);
-    assertNotSuggested('g');
-    assertNotSuggested('x');
-  }
-
   test_CatchClause_typed() {
     // Block  CatchClause  TryStatement
     addTestSource('class A {a() {try{} on E catch (e) {^}}}');
     expect(computeFast(), isTrue);
     assertSuggestParameter('e', 'E');
   }
 
   test_CatchClause_untyped() {
     // Block  CatchClause  TryStatement
     addTestSource('class A {a() {try{} catch (e, s) {^}}}');
@@ skipping 213 matching lines @@
     // VariableDeclaration  VariableDeclarationList
     // VariableDeclarationStatement
     addTestSource('class A {a() {var f; {var x;} var e = ^ var g;}}');
     expect(computeFast(), isTrue);
     assertSuggestClass('A');
     assertSuggestLocalVariable('f', null);
     assertNotSuggested('g');
     assertNotSuggested('x');
   }
 
-  //TODO (danrubel) implement
   xtest_ConstructorName_importedClass() {
     // SimpleIdentifier  PrefixedIdentifier  TypeName  ConstructorName
     // InstanceCreationExpression
     addSource('/testB.dart', '''
       lib B;
       class X {X.c(); X._d(); z() {}}''');
     addTestSource('''
       import "/testB.dart";
       var m;
       main() {new X.^}''');
     return computeFull().then((_) {
       assertNoSuggestions();
     });
   }
 
-  //TODO (danrubel) implement
   xtest_ConstructorName_localClass() {
     // SimpleIdentifier  PrefixedIdentifier  TypeName  ConstructorName
     // InstanceCreationExpression
     addTestSource('''
       var m;
       class X {X.c(); X._d(); z() {}}
       main() {new X.^}''');
     return computeFull().then((_) {
       assertNoSuggestions();
     });
   }
 
-  //TODO (danrubel) implement
   xtest_InstanceCreationExpression() {
     // SimpleIdentifier  TypeName  ConstructorName  InstanceCreationExpression
     addTestSource('class A {a() {var f; {var x;} new ^}} class B { }');
     expect(computeFast(), isTrue);
     assertSuggestClass('A');
     assertSuggestClass('B');
     assertNotSuggested('a');
     assertNotSuggested('f');
     assertNotSuggested('x');
   }
 
-  //TODO (danrubel) implement
   xtest_IsExpression_imported() {
     // SimpleIdentifier  TypeName  IsExpression  IfStatement
     addSource('/testB.dart', '''
       lib B;
       class X {X.c(); X._d(); z() {}}''');
     addTestSource('''
       import "/testB.dart";
       main() {var x; if (x is ^) { }}''');
     return computeFull().then((_) {
       assertNoSuggestions();
     });
   }
 
-  //TODO (danrubel) implement
   xtest_IsExpression_local() {
     // SimpleIdentifier  TypeName  IsExpression  IfStatement
     addTestSource('''
       class X {X.c(); X._d(); z() {}}
       main() {var x; if (x is ^) { }}''');
     return computeFull().then((_) {
       assertSuggestConstructor('c');
       assertNotSuggested('main');
       assertNotSuggested('X');
       assertNotSuggested('B');
       assertNotSuggested('x');
     });
   }
 }