local cascade suggestion fix and move towards common tests

pkg/analysis_server/test/services/completion/invocation_computer_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.invocation;
 
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/invocation_computer.dart';
 import 'package:unittest/unittest.dart';
 
 import '../../reflective_tests.dart';
 import 'completion_test_util.dart';
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(InvocationComputerTest);
 }
 
 @ReflectiveTestCase()
-class InvocationComputerTest extends AbstractCompletionTest {
+class InvocationComputerTest extends AbstractSelectorSuggestionTest {
 
   @override
   void setUp() {
     super.setUp();
     computer = new InvocationComputer();
   }
 
-  test_CascadeExpression_selector1() {
-    // PropertyAccess  CascadeExpression  ExpressionStatement
-    addTestSource('''
-      class A {var b; X _c;}
-      class X{}
-      // looks like a cascade to the parser
-      // but the user is trying to get completions for a non-cascade
-      main() {A a; a.^.b}''');
-    return computeFull(true).then((_) {
-      assertSuggestGetter('b', null);
-      assertSuggestGetter('_c', 'X');
-    });
-  }
-
-  test_CascadeExpression_selector2() {
-    // PropertyAccess  CascadeExpression  ExpressionStatement
-    addTestSource('''
-      class A {var b; X _c;}
-      class X{}
-      main() {A a; a..^b}''');
-    return computeFull().then((_) {
-      assertSuggestGetter('b', null);
-      assertSuggestGetter('_c', 'X');
-    });
-  }
-
   test_CascadeExpression_target() {
     // PropertyAccess  CascadeExpression  ExpressionStatement
     addTestSource('''
       class A {var b; X _c;}
       class X{}
       main() {A a; a^..b}''');
     return computeFull().then((_) {
       assertNotSuggested('b');
       assertNotSuggested('_c');
     });
@@ skipping 25 matching lines @@
       class X {X.c(); X._d(); z() {}}
       main() {new X.^}''');
     return computeFull().then((_) {
       assertSuggest(CompletionSuggestionKind.CONSTRUCTOR, 'c');
       assertSuggest(CompletionSuggestionKind.CONSTRUCTOR, '_d');
       assertNotSuggested('z');
       assertNotSuggested('m');
     });
   }
 
+  test_IsExpression() {
+    // SimpleIdentifier  TypeName  IsExpression  IfStatement
+    addSource('/testB.dart', '''
+      lib B;
+      class X {X.c(); X._d(); z() {}}''');
+    addTestSource('''
+      import "/testB.dart";
+      main() {var x; if (x is ^) { }}''');
+    return computeFull().then((_) {
+      assertNoSuggestions();
+    });
+  }
+
   test_PrefixedIdentifier_field() {
     // SimpleIdentifier  PrefixedIdentifier  ExpressionStatement
     addTestSource('''
       class A {var b; X _c;}
       class X{}
       main() {A a; a.^}''');
     return computeFull().then((_) {
       assertSuggestGetter('b', null);
       assertSuggestGetter('_c', 'X');
     });
@@ skipping 158 matching lines @@
       lib B;
       class X {set y(X x) {} set _z(X x) {}}''');
     addTestSource('''
       import "/testB.dart";
       main() {X x; x.^}''');
     return computeFull().then((_) {
       assertSuggestSetter('y');
       assertNotSuggested('_z');
     });
   }
-
-  //TODO (danrubel) implement
-  xtest_IsExpression() {
-    // SimpleIdentifier  TypeName  IsExpression  IfStatement
-    addSource('/testB.dart', '''
-      lib B;
-      class X {X.c(); X._d(); z() {}}''');
-    addTestSource('''
-      import "/testB.dart";
-      main() {var x; if (x is ^) { }}''');
-    return computeFull().then((_) {
-      assertNoSuggestions();
-    });
-  }
 }