base/json/json_file_value_serializer.h - Issue 632103004: Cleanup: Better constify some strings in base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_file_value_serializer.h

Issue 632103004: Cleanup: Better constify some strings in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix bad refactoring Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/json/json_file_value_serializer.h

diff --git a/base/json/json_file_value_serializer.h b/base/json/json_file_value_serializer.h

index fc12b6be51d2a103fdef252530023704d9b93ae4..642729f8f5c25f5c44563dcfedfcbdef5be8129b 100644

--- a/base/json/json_file_value_serializer.h

+++ b/base/json/json_file_value_serializer.h

@@ -58,10 +58,10 @@ class BASE_EXPORT JSONFileValueSerializer : public base::ValueSerializer {

};

// File-specific error messages that can be returned.

- static const char* kAccessDenied;

- static const char* kCannotReadFile;

- static const char* kFileLocked;

- static const char* kNoSuchFile;

+ static const char kAccessDenied[];

+ static const char kCannotReadFile[];

+ static const char kFileLocked[];

+ static const char kNoSuchFile[];

// Convert an error code into an error message. |error_code| is assumed to

// be a JsonFileError.

« no previous file with comments | « base/i18n/break_iterator_unittest.cc ('k') | base/json/json_file_value_serializer.cc » ('j') | no next file with comments »