base/json/json_file_value_serializer.cc - Issue 632103004: Cleanup: Better constify some strings in base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_file_value_serializer.cc

Issue 632103004: Cleanup: Better constify some strings in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix bad refactoring Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/json/json_file_value_serializer.cc

diff --git a/base/json/json_file_value_serializer.cc b/base/json/json_file_value_serializer.cc

index d7d54f2e9118fb53b6d89bbd4786d2f2b244bbdd..d60f800cfcfbb9235fc62fc050feb98c87a54740 100644

--- a/base/json/json_file_value_serializer.cc

+++ b/base/json/json_file_value_serializer.cc

@@ -10,10 +10,10 @@

using base::FilePath;

-const char* JSONFileValueSerializer::kAccessDenied = "Access denied.";

-const char* JSONFileValueSerializer::kCannotReadFile = "Can't read file.";

-const char* JSONFileValueSerializer::kFileLocked = "File locked.";

-const char* JSONFileValueSerializer::kNoSuchFile = "File doesn't exist.";

+const char JSONFileValueSerializer::kAccessDenied[] = "Access denied.";

+const char JSONFileValueSerializer::kCannotReadFile[] = "Can't read file.";

+const char JSONFileValueSerializer::kFileLocked[] = "File locked.";

+const char JSONFileValueSerializer::kNoSuchFile[] = "File doesn't exist.";

bool JSONFileValueSerializer::Serialize(const base::Value& root) {

return SerializeInternal(root, false);

« no previous file with comments | « base/json/json_file_value_serializer.h ('k') | base/json/json_parser.cc » ('j') | no next file with comments »