Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Side by Side Diff: base/json/json_file_value_serializer.h

Issue 632103004: Cleanup: Better constify some strings in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bad refactoring Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/i18n/break_iterator_unittest.cc ('k') | base/json/json_file_value_serializer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_ 5 #ifndef BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
6 #define BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_ 6 #define BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/base_export.h" 10 #include "base/base_export.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 // This enum is designed to safely overlap with JSONReader::JsonParseError. 51 // This enum is designed to safely overlap with JSONReader::JsonParseError.
52 enum JsonFileError { 52 enum JsonFileError {
53 JSON_NO_ERROR = 0, 53 JSON_NO_ERROR = 0,
54 JSON_ACCESS_DENIED = 1000, 54 JSON_ACCESS_DENIED = 1000,
55 JSON_CANNOT_READ_FILE, 55 JSON_CANNOT_READ_FILE,
56 JSON_FILE_LOCKED, 56 JSON_FILE_LOCKED,
57 JSON_NO_SUCH_FILE 57 JSON_NO_SUCH_FILE
58 }; 58 };
59 59
60 // File-specific error messages that can be returned. 60 // File-specific error messages that can be returned.
61 static const char* kAccessDenied; 61 static const char kAccessDenied[];
62 static const char* kCannotReadFile; 62 static const char kCannotReadFile[];
63 static const char* kFileLocked; 63 static const char kFileLocked[];
64 static const char* kNoSuchFile; 64 static const char kNoSuchFile[];
65 65
66 // Convert an error code into an error message. |error_code| is assumed to 66 // Convert an error code into an error message. |error_code| is assumed to
67 // be a JsonFileError. 67 // be a JsonFileError.
68 static const char* GetErrorMessageForCode(int error_code); 68 static const char* GetErrorMessageForCode(int error_code);
69 69
70 void set_allow_trailing_comma(bool new_value) { 70 void set_allow_trailing_comma(bool new_value) {
71 allow_trailing_comma_ = new_value; 71 allow_trailing_comma_ = new_value;
72 } 72 }
73 73
74 private: 74 private:
75 bool SerializeInternal(const base::Value& root, bool omit_binary_values); 75 bool SerializeInternal(const base::Value& root, bool omit_binary_values);
76 76
77 base::FilePath json_file_path_; 77 base::FilePath json_file_path_;
78 bool allow_trailing_comma_; 78 bool allow_trailing_comma_;
79 79
80 // A wrapper for ReadFileToString which returns a non-zero JsonFileError if 80 // A wrapper for ReadFileToString which returns a non-zero JsonFileError if
81 // there were file errors. 81 // there were file errors.
82 int ReadFileToString(std::string* json_string); 82 int ReadFileToString(std::string* json_string);
83 83
84 DISALLOW_IMPLICIT_CONSTRUCTORS(JSONFileValueSerializer); 84 DISALLOW_IMPLICIT_CONSTRUCTORS(JSONFileValueSerializer);
85 }; 85 };
86 86
87 #endif // BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_ 87 #endif // BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
88 88
OLDNEW
« no previous file with comments | « base/i18n/break_iterator_unittest.cc ('k') | base/json/json_file_value_serializer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698