[GCM] Fetching OAuth2 tokens periodically in account tracker

components/gcm_driver/gcm_driver_desktop.cc

Index: components/gcm_driver/gcm_driver_desktop.cc
diff --git a/components/gcm_driver/gcm_driver_desktop.cc b/components/gcm_driver/gcm_driver_desktop.cc
index 6902efbc85e0a91ed49755198fd22a9ac052e9d8..86f2e481ab7273fc5350127a73af8542385383df 100644
--- a/components/gcm_driver/gcm_driver_desktop.cc
+++ b/components/gcm_driver/gcm_driver_desktop.cc
@@ -363,6 +363,7 @@ GCMDriverDesktop::GCMDriverDesktop(
       gcm_enabled_(true),
       connected_(false),
       account_mapper_(new GCMAccountMapper(this)),
+      last_token_fetch_time_(base::Time::Max()),  // set to max as a sentinel

[Nicolas Zea, 2014/11/06 21:43:17]

Why Max, vs null?

[fgorski, 2014/11/07 01:42:13]

Max > Now() which means reporting will not be triggered until date in the past
(perhaps Min) is read from the DB and set here. I added a comment that tries to
address that.

In short. Null or Min (meaning never happend, are valid values that will trigger
activity)

In cases when tokens have been reported in the past we might wipe that
information and then again populate it. Once the read from DB is over, we are in
a much safer situation.

       ui_thread_(ui_thread),
       io_thread_(io_thread),
       weak_ptr_factory_(this) {