chrome/browser/services/gcm/gcm_profile_service.cc - Issue 631343002: [GCM] Fetching OAuth2 tokens periodically in account tracker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/gcm_profile_service.cc

Issue 631343002: [GCM] Fetching OAuth2 tokens periodically in account tracker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mapper-in-driver

Patch Set: Adding tests and removing pref related code from tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/gcm_account_tracker.cc ('K') | « chrome/browser/services/gcm/gcm_account_tracker_unittest.cc ('k') | components/gcm_driver/gcm_driver_desktop.cc » ('j') | components/gcm_driver/gcm_driver_desktop.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/gcm_profile_service.cc

diff --git a/chrome/browser/services/gcm/gcm_profile_service.cc b/chrome/browser/services/gcm/gcm_profile_service.cc

index 018cbe6037ab0f223e1ba3fb8e3278963b96ba9e..e7741c40ae537f7c2059691c418de1234cb9ac6b 100644

--- a/chrome/browser/services/gcm/gcm_profile_service.cc

+++ b/chrome/browser/services/gcm/gcm_profile_service.cc

@@ -112,7 +112,6 @@ void GCMProfileService::IdentityObserver::OnActiveAccountLogout() {

std::string GCMProfileService::IdentityObserver::SignedInUserName() const {

return driver_->IsStarted() ? account_id_ : std::string();

}

Nicolas Zea 2014/11/06 21:43:17 Did you mean to remove this?

fgorski 2014/11/07 01:42:13 Done. Definitely an accident.

void GCMProfileService::IdentityObserver::StartAccountTracker() {

if (gcm_account_tracker_)

return;