[GCM] Fetching OAuth2 tokens periodically in account tracker

components/gcm_driver/gcm_driver_desktop.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/gcm_driver/gcm_driver_desktop.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 345 matching lines @@
           new GCMChannelStatusSyncer(this,
                                      prefs,
                                      channel_status_request_url,
                                      user_agent,
                                      request_context)),
       signed_in_(false),
       gcm_started_(false),
       gcm_enabled_(true),
       connected_(false),
       account_mapper_(new GCMAccountMapper(this)),
+      last_token_fetch_time_(base::Time::Max()),  // set to max as a sentinel

[Nicolas Zea, 2014/11/06 21:43:17]

Why Max, vs null?

[fgorski, 2014/11/07 01:42:13]

Max > Now() which means reporting will not be triggered until date in the past
(perhaps Min) is read from the DB and set here. I added a comment that tries to
address that.

In short. Null or Min (meaning never happend, are valid values that will trigger
activity)

In cases when tokens have been reported in the past we might wipe that
information and then again populate it. Once the read from DB is over, we are in
a much safer situation.

       ui_thread_(ui_thread),
       io_thread_(io_thread),
       weak_ptr_factory_(this) {
   gcm_enabled_ = gcm_channel_status_syncer_->gcm_enabled();
 
   // Create and initialize the GCMClient. Note that this does not initiate the
   // GCM check-in.
   io_worker_.reset(new IOWorker(ui_thread, io_thread));
   io_thread_->PostTask(
       FROM_HERE,
@@ skipping 436 matching lines @@
 
   // Normally request_gcm_statistics_callback_ would not be null.
   if (!request_gcm_statistics_callback_.is_null())
     request_gcm_statistics_callback_.Run(stats);
   else
     LOG(WARNING) << "request_gcm_statistics_callback_ is NULL.";
 }
 
 }  // namespace gcm