Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: grit/format/policy_templates/writers/json_writer_unittest.py

Issue 631223003: Include chromium version number in policy templates (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: grit/format/policy_templates/writers/json_writer_unittest.py
===================================================================
--- grit/format/policy_templates/writers/json_writer_unittest.py (revision 177)
+++ grit/format/policy_templates/writers/json_writer_unittest.py (working copy)
@@ -24,7 +24,16 @@
{
"""
+TEMPLATE_HEADER_WITH_VERSION="""\
+// chromium version: 39.0.0.0
+// Policy template for Linux.
+// Uncomment the policies you wish to activate and change their values to
+// something useful for your case. The provided values are for reference only
+// and do not provide meaningful defaults!
+{
+"""
+
HEADER_DELIMETER="""\
//-------------------------------------------------------------------------
"""
@@ -55,10 +64,23 @@
' "placeholders": [],'
' "messages": {},'
'}')
- output = self.GetOutput(grd, 'fr', {'_chromium': '1',}, 'json', 'en')
+ output = self.GetOutput(grd, 'fr', {'_chromium': '1'}, 'json', 'en')
expected_output = TEMPLATE_HEADER + '}'
self.CompareOutputs(output, expected_output)
+ def testEmptyWithVersion(self):
+ # Test the handling of an empty policy list.
+ grd = self.PrepareTest(
+ '{'
+ ' "policy_definitions": [],'
+ ' "placeholders": [],'
+ ' "messages": {},'
+ '}')
+ output = self.GetOutput(
+ grd, 'fr', {'_chromium': '1', 'version':'39.0.0.0'}, 'json', 'en')
+ expected_output = TEMPLATE_HEADER_WITH_VERSION + '}'
+ self.CompareOutputs(output, expected_output)
+
def testMainPolicy(self):
# Tests a policy group with a single policy of type 'main'.
grd = self.PrepareTest(
« no previous file with comments | « grit/format/policy_templates/writers/json_writer.py ('k') | grit/format/policy_templates/writers/plist_strings_writer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698