Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: grit/format/policy_templates/writers/plist_strings_writer.py

Issue 631223003: Include chromium version number in policy templates (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: grit/format/policy_templates/writers/plist_strings_writer.py
===================================================================
--- grit/format/policy_templates/writers/plist_strings_writer.py (revision 177)
+++ grit/format/policy_templates/writers/plist_strings_writer.py (working copy)
@@ -22,6 +22,9 @@
[lang].lproj subdirectories of the manifest bundle.
'''
+ def WriteComment(self, comment):
+ self._out.append('/* ' + comment + ' */' )
+
def _AddToStringTable(self, item_name, caption, desc):
'''Add a title and a description of an item to the string table.
@@ -63,6 +66,9 @@
def BeginTemplate(self):
app_name = plist_helper.GetPlistFriendlyName(self.config['app_name'])
+ if self._GetChromiumVersionString() is not None:
+ self.WriteComment(self.config['build'] + ''' version: ''' + \
+ self._GetChromiumVersionString())
self._AddToStringTable(
app_name,
self.config['app_name'],

Powered by Google App Engine
This is Rietveld 408576698