Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: grit/format/policy_templates/writers/json_writer.py

Issue 631223003: Include chromium version number in policy templates (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: grit/format/policy_templates/writers/json_writer.py
===================================================================
--- grit/format/policy_templates/writers/json_writer.py (revision 177)
+++ grit/format/policy_templates/writers/json_writer.py (working copy)
@@ -39,6 +39,9 @@
def PreprocessPolicies(self, policy_list):
return self.FlattenGroupsAndSortPolicies(policy_list)
+ def WriteComment(self, comment):
+ self._out.append('// ' + comment)
+
def WritePolicy(self, policy):
if policy['type'] == 'external':
# This type can only be set through cloud policy.
@@ -69,6 +72,9 @@
self._first_written = False
def BeginTemplate(self):
+ if self._GetChromiumVersionString() is not None:
+ self.WriteComment(self.config['build'] + ''' version: ''' + \
+ self._GetChromiumVersionString())
self._out.append(TEMPLATE_HEADER)
def EndTemplate(self):

Powered by Google App Engine
This is Rietveld 408576698