Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 631183003: Revert of gl programs rewrite (Closed)

Created:
6 years, 2 months ago by joshua.litt
Modified:
6 years, 2 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of gl programs rewrite (patchset #10 id:180001 of https://codereview.chromium.org/628633003/) Reason for revert: breaks angle bot Original issue's description: > gl programs rewrite > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/07a255310aca9f3e83bf741dc663a58818ad681c TBR=bsalomon@google.com,egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/d909759832d5a6bb476597098e05bbe7ba0ccbd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -378 lines) Patch
M include/gpu/GrProcessor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrTypes.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 2 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/GLProgramsTest.cpp View 4 chunks +268 lines, -340 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshua.litt
Created Revert of gl programs rewrite
6 years, 2 months ago (2014-10-07 15:36:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631183003/1
6 years, 2 months ago (2014-10-07 15:37:26 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 15:37:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as d909759832d5a6bb476597098e05bbe7ba0ccbd2

Powered by Google App Engine
This is Rietveld 408576698