Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 630993005: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/animation (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West, dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/animation This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183341

Patch Set 1 #

Patch Set 2 : Added cpp to list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -208 lines) Patch
M Source/core/animation/Animation.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/animation/AnimationNodeTest.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/animation/AnimationTimeline.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorPendingAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DefaultStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/InertAnimation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/InterpolableValue.h View 5 chunks +16 lines, -16 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/LegacyStyleInterpolation.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/StringKeyframe.h View 2 chunks +10 lines, -12 lines 0 comments Download
M Source/core/animation/StyleInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableClipPathOperation.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/animatable/AnimatableColor.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/animatable/AnimatableDouble.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/animation/animatable/AnimatableFilterOperations.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/animatable/AnimatableImage.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLength.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthBox.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthBoxAndBool.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthPoint.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthPoint3D.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthSize.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableNeutral.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableRepeatable.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableSVGLength.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableSVGPaint.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/animatable/AnimatableShadow.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableShapeValue.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/animatable/AnimatableStrokeDasharrayList.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableTransform.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknown.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueKeyframe.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/animation/animatable/AnimatableVisibility.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/css/CSSAnimationData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/animation/css/CSSTransitionData.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 11:53:53 UTC) #2
Mike West
LGTM.
6 years, 2 months ago (2014-10-07 12:54:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630993005/20001
6 years, 2 months ago (2014-10-07 12:56:20 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 14:44:27 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183341

Powered by Google App Engine
This is Rietveld 408576698