Issue 6304003: Use the new WebViewClient::createView signature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6304003: Use the new WebViewClient::createView signature. (Closed)

Created:
9 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), jnd

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use the new WebViewClient::createView signature. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71432

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -0 lines)			Patch
M	chrome/renderer/render_view.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

webkit side is here: https://bugs.webkit.org/show_bug.cgi?id=52437 please review

9 years, 11 months ago (2011-01-14 10:25:11 UTC) #1

jnd

9 years, 11 months ago (2011-01-14 10:41:23 UTC) #2

LGTM.

Thanks for fixing it, it reduced my patch for crbug.com/38458.

On 2011/01/14 10:25:11, jochen wrote:
> webkit side is here: https://bugs.webkit.org/show_bug.cgi?id=52437
> 
> please review

Expand Messages | Collapse Messages