Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: webkit/tools/test_shell/test_webview_delegate.cc

Issue 6304003: Use the new WebViewClient::createView signature. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/test_shell/test_webview_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/test_webview_delegate.cc
diff --git a/webkit/tools/test_shell/test_webview_delegate.cc b/webkit/tools/test_shell/test_webview_delegate.cc
index fccf8e7d78f0bd03f2cd05c8a382449081aef1be..305fa1fad830ec42df32423690f66fd946807cfc 100644
--- a/webkit/tools/test_shell/test_webview_delegate.cc
+++ b/webkit/tools/test_shell/test_webview_delegate.cc
@@ -329,10 +329,19 @@ void TestWebViewDelegate::SetAuthorAndUserStylesEnabled(bool is_enabled) {
}
// WebViewClient -------------------------------------------------------------
+// TODO(jochen): remove once webkit side is up to date.
WebView* TestWebViewDelegate::createView(
WebFrame* creator,
const WebWindowFeatures& window_features,
const WebString& frame_name) {
+ return createView(creator, WebURLRequest(), window_features, frame_name);
+}
+
+WebView* TestWebViewDelegate::createView(
+ WebFrame* creator,
+ const WebURLRequest& request,
+ const WebWindowFeatures& window_features,
+ const WebString& frame_name) {
return shell_->CreateWebView();
}
« no previous file with comments | « webkit/tools/test_shell/test_webview_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698