Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5752)

Unified Diff: chrome/renderer/render_view.cc

Issue 6304003: Use the new WebViewClient::createView signature. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view.h ('k') | webkit/tools/test_shell/test_webview_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.cc
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index 11847de4815f99a5fb013f407fda652866d49345..847756590299f04d9f55fc0ad0bb2ed91057af69 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -2061,10 +2061,19 @@ void RenderView::OnMissingPluginStatus(
// WebKit::WebViewClient ------------------------------------------------------
+// TODO(jochen): remove once WebKit side is up to date.
WebView* RenderView::createView(
WebFrame* creator,
const WebWindowFeatures& features,
const WebString& frame_name) {
+ return createView(creator, WebURLRequest(), features, frame_name);
+}
+
+WebView* RenderView::createView(
+ WebFrame* creator,
+ const WebURLRequest& request,
+ const WebWindowFeatures& features,
+ const WebString& frame_name) {
// Check to make sure we aren't overloading on popups.
if (shared_popup_counter_->data > kMaximumNumberOfUnacknowledgedPopups)
return NULL;
« no previous file with comments | « chrome/renderer/render_view.h ('k') | webkit/tools/test_shell/test_webview_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698