Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: Source/platform/graphics/GraphicsLayer.cpp

Issue 629583002: Make compositor and blink talk in fractional scroll offset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/GraphicsLayer.cpp
diff --git a/Source/platform/graphics/GraphicsLayer.cpp b/Source/platform/graphics/GraphicsLayer.cpp
index 0f7d6acd45c69d18c37e9cd14414cc07982741da..2d3a0209d7f2ac220e63b5c54b23f7c40bc6c12d 100644
--- a/Source/platform/graphics/GraphicsLayer.cpp
+++ b/Source/platform/graphics/GraphicsLayer.cpp
@@ -1057,8 +1057,10 @@ void GraphicsLayer::notifyAnimationFinished(double, WebCompositorAnimation::Targ
void GraphicsLayer::didScroll()
{
- if (m_scrollableArea)
- m_scrollableArea->scrollToOffsetWithoutAnimation(m_scrollableArea->minimumScrollPosition() + toIntSize(m_layer->layer()->scrollPosition()));
+ if (m_scrollableArea) {
+ DoublePoint newPosition = m_scrollableArea->minimumScrollPosition() + toDoubleSize(m_layer->layer()->scrollPositionDouble());
+ m_scrollableArea->scrollToOffsetWithoutAnimation(toFloatPoint(newPosition));
Rick Byers 2014/10/04 00:04:24 FIXME to remove the 'toFloatPoint' (like all the o
Yufeng Shen (Slow to review) 2014/10/06 17:54:58 Done.
+ }
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698