Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 629583002: Make compositor and blink talk in fractional scroll offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 629583002: Make compositor and blink talk in fractional scroll offset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/scrolling/fractional-scroll-offset-document.html ('K') | « LayoutTests/fast/scrolling/fractional-scroll-offset-document-expected.txt ('k') | Source/platform/graphics/GraphicsLayer.cpp » ('j') | Source/platform/graphics/GraphicsLayer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/Source/core/page/scrolling/ScrollingCoordinator.cpp b/Source/core/page/scrolling/ScrollingCoordinator.cpp

index a0ef870fad59d9896b57570a6e806bd48bd87d5c..4784f8db7b5a475a9a5d372440a532d0694c28a1 100644

--- a/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -359,7 +359,7 @@ bool ScrollingCoordinator::scrollableAreaScrollLayerDidChange(ScrollableArea* sc

WebLayer* containerLayer = toWebLayer(scrollableArea->layerForContainer());

if (webLayer) {

webLayer->setScrollClipLayer(containerLayer);

- webLayer->setScrollPosition(IntPoint(scrollableArea->scrollPosition() - scrollableArea->minimumScrollPosition()));

+ webLayer->setScrollPositionDouble(DoublePoint(scrollableArea->scrollPositionDouble() - scrollableArea->minimumScrollPosition()));

webLayer->setBounds(scrollableArea->contentsSize());

bool canScrollX = scrollableArea->userInputScrollable(HorizontalScrollbar);

bool canScrollY = scrollableArea->userInputScrollable(VerticalScrollbar);