Source/platform/graphics/GraphicsLayerTest.cpp - Issue 629583002: Make compositor and blink talk in fractional scroll offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/GraphicsLayerTest.cpp

Issue 629583002: Make compositor and blink talk in fractional scroll offset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/GraphicsLayer.cpp ('K') | « Source/platform/graphics/GraphicsLayer.cpp ('k') | Source/web/tests/ScrollingCoordinatorChromiumTest.cpp » ('j') | Source/web/tests/ScrollingCoordinatorChromiumTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/GraphicsLayerTest.cpp

diff --git a/Source/platform/graphics/GraphicsLayerTest.cpp b/Source/platform/graphics/GraphicsLayerTest.cpp

index df17919d04ca8431f22eb141a1d539ecc0ae8054..ea9bf233998f03bbc6c9a007069bb933d45b5291 100644

--- a/Source/platform/graphics/GraphicsLayerTest.cpp

+++ b/Source/platform/graphics/GraphicsLayerTest.cpp

@@ -157,11 +157,12 @@ TEST_F(GraphicsLayerTest, applyScrollToScrollableArea)

FakeScrollableArea scrollableArea;

m_graphicsLayer->setScrollableArea(&scrollableArea, false);

- WebPoint scrollPosition(7, 9);

- m_platformLayer->setScrollPosition(scrollPosition);

+ WebDoublePoint scrollPosition(7, 9);

Rick Byers 2014/10/04 00:04:24 Can you change these to be fractional, just to ver

Yufeng Shen (Slow to review) 2014/10/06 17:54:58 Done.

+ m_platformLayer->setScrollPositionDouble(scrollPosition);

m_graphicsLayer->didScroll();

- EXPECT_EQ(scrollPosition, WebPoint(scrollableArea.scrollPosition()));

+ EXPECT_EQ(scrollPosition.x, scrollableArea.scrollPositionDouble().x());

+ EXPECT_EQ(scrollPosition.y, scrollableArea.scrollPositionDouble().y());

}

} // namespace