Adding roles in Blink side to expose menuitemcheckbox & menuitemradio role with correct IA2 role.

Adding roles in Blink side to expose aria role menuitemcheckbox and menuitemradio with correct IA2 role in Chromium Side.

According to specs(http://www.w3.org/WAI/PF/aria-implementation/)

aria role menuitemcheckbox should have IA2 role as IA2_ROLE_CHECK_MENU_ITEM
aria role menuitemradio should have IA2 role as IA2_ROLE_RADIO_MENU_ITEM

BUG=169569, 420605
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183304

[shreeramk, 2014-10-06 15:56:22]

shreeram.k@samsung.com changed reviewers:
+ aboxhall@chromium.org

[shreeramk, 2014-10-06 15:56:23]

Please review.

Thanks!

[dmazzoni, 2014-10-06 16:02:24]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2014-10-06 16:02:24]

lgtm

[shreeramk, 2014-10-06 17:33:58]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-10-06 17:34:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/629003003/1

[commit-bot: I haz the power, 2014-10-06 20:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-06 20:35:50]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[shreeramk, 2014-10-07 03:39:33]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-10-07 03:41:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/629003003/1

[commit-bot: I haz the power, 2014-10-07 04:29:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-07 04:29:03]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[shreeramk, 2014-10-07 05:04:28]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-10-07 05:05:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/629003003/1

[commit-bot: I haz the power, 2014-10-07 05:59:03]

Committed patchset #1 (id:1) as 183304

[dmazzoni, 2014-10-10 05:42:51]

https://codereview.chromium.org/629003003/diff/1/public/web/WebAXEnums.h
File public/web/WebAXEnums.h (right):

https://codereview.chromium.org/629003003/diff/1/public/web/WebAXEnums.h#newc...
public/web/WebAXEnums.h:142: WebAXRoleMenuItemCheckBox,
I just realized that you previously added WebAXRoleCheckBoxMenuItem a week
before - how is WebAXRoleMenuItemCheckBox different? I don't think we should
have both.

[shreeramk, 2014-10-10 06:23:49]

On 2014/10/10 05:42:51, dmazzoni wrote:
> https://codereview.chromium.org/629003003/diff/1/public/web/WebAXEnums.h
> File public/web/WebAXEnums.h (right):
> 
>
https://codereview.chromium.org/629003003/diff/1/public/web/WebAXEnums.h#newc...
> public/web/WebAXEnums.h:142: WebAXRoleMenuItemCheckBox,
> I just realized that you previously added WebAXRoleCheckBoxMenuItem a week
> before - how is WebAXRoleMenuItemCheckBox different? I don't think we should
> have both.

Yes its on purpose.
I introduce two roles because mac(AX) spec differs for aria role
menuitemcheckbox and input type checkbox with menu as parent.

Input type checkbox with menu as parent-

AX: ?

For aria role menuitemcheckbox:

AX: 
AXRole:AXMenuItem
AXSubRole: <nil>
AXRoleDescription:'menu item'
If aria-checked (state)="true": AXMenuItemMarkChar ✓
Otherwise: AXMenuItemMarkChar <nil>

[dmazzoni, 2014-10-10 21:05:18]

I interpret the '?' as meaning that the authors of the spec haven't gotten
around to filling this in yet, not that it should be different.

I just don't see any reason we should handle these differently. I think we
should just make them the same, and file a bug with the spec to fix it.

If there is a really good reason to handle them differently, the names
should be more clear and indicate the difference.

On Thu, Oct 9, 2014 at 11:23 PM, <shreeram.k@samsung.com> wrote:

> On 2014/10/10 05:42:51, dmazzoni wrote:
>
>> https://codereview.chromium.org/629003003/diff/1/public/web/WebAXEnums.h
>> File public/web/WebAXEnums.h (right):
>>
>
>
> https://codereview.chromium.org/629003003/diff/1/public/
> web/WebAXEnums.h#newcode142
>
>> public/web/WebAXEnums.h:142: WebAXRoleMenuItemCheckBox,
>> I just realized that you previously added WebAXRoleCheckBoxMenuItem a week
>> before - how is WebAXRoleMenuItemCheckBox different? I don't think we
>> should
>> have both.
>>
>
> Yes its on purpose.
> I introduce two roles because mac(AX) spec differs for aria role
> menuitemcheckbox and input type checkbox with menu as parent.
>
> Input type checkbox with menu as parent-
>
> AX: ?
>
> For aria role menuitemcheckbox:
>
> AX:
> AXRole:AXMenuItem
> AXSubRole: <nil>
> AXRoleDescription:'menu item'
> If aria-checked (state)="true": AXMenuItemMarkChar ✓
> Otherwise: AXMenuItemMarkChar <nil>
>
> https://codereview.chromium.org/629003003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-10-12 09:19:06]

Please find the inline comments. :)

On 2014/10/10 21:05:18, dmazzoni wrote:
> I interpret the '?' as meaning that the authors of the spec haven't gotten
> around to filling this in yet, not that it should be different.

OK. I was not able to interpret the meaning of '?'.

> I just don't see any reason we should handle these differently. I think we
> should just make them the same, and file a bug with the spec to fix it.

I will file a spec bug.

> If there is a really good reason to handle them differently, the names
> should be 
 clear and indicate the difference.

I think then we shouldn't handle them differetly. I ll upload a blink side CL to
use a common name i.e MenuItemCheckBox

> On Thu, Oct 9, 2014 at 11:23 PM, <mailto:shreeram.k@samsung.com> wrote:
> 
> > On 2014/10/10 05:42:51, dmazzoni wrote:
> >
> >> https://codereview.chromium.org/629003003/diff/1/public/web/WebAXEnums.h
> >> File public/web/WebAXEnums.h (right):
> >>
> >
> >
> > https://codereview.chromium.org/629003003/diff/1/public/
> > web/WebAXEnums.h#newcode142
> >
> >> public/web/WebAXEnums.h:142: WebAXRoleMenuItemCheckBox,
> >> I just realized that you previously added WebAXRoleCheckBoxMenuItem a week
> >> before - how is WebAXRoleMenuItemCheckBox different? I don't think we
> >> should
> >> have both.
> >>
> >
> > Yes its on purpose.
> > I introduce two roles because mac(AX) spec differs for aria role
> > menuitemcheckbox and input type checkbox with menu as parent.
> >
> > Input type checkbox with menu as parent-
> >
> > AX: ?
> >
> > For aria role menuitemcheckbox:
> >
> > AX:
> > AXRole:AXMenuItem
> > AXSubRole: <nil>
> > AXRoleDescription:'menu item'
> > If aria-checked (state)="true": AXMenuItemMarkChar ✓
> > Otherwise: AXMenuItemMarkChar <nil>
> >
> > https://codereview.chromium.org/629003003/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-10-12 10:48:14]

On 2014/10/12 09:19:06, shreeram.k wrote:
> Please find the inline comments. :)
> 
> On 2014/10/10 21:05:18, dmazzoni wrote:
> > I interpret the '?' as meaning that the authors of the spec haven't gotten
> > around to filling this in yet, not that it should be different.
> 
> OK. I was not able to interpret the meaning of '?'.
> 
> > I just don't see any reason we should handle these differently. I think we
> > should just make them the same, and file a bug with the spec to fix it.
> 
> I will file a spec bug.
> 

Spec bug filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=27024