Source/core/accessibility/AXObject.cpp - Issue 629003003: Adding roles in Blink side to expose menuitemcheckbox & menuitemradio role with correct IA2 role.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXObject.cpp

Issue 629003003: Adding roles in Blink side to expose menuitemcheckbox & menuitemradio role with correct IA2 role. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/accessibility/AXObject.cpp

diff --git a/Source/core/accessibility/AXObject.cpp b/Source/core/accessibility/AXObject.cpp

index 1b68e94a7fbcf98e1e814eefba9b4962f64e4a8b..c296ddfbda8c8dcc53211a281e49abb716bcb372 100644

--- a/Source/core/accessibility/AXObject.cpp

+++ b/Source/core/accessibility/AXObject.cpp

@@ -91,8 +91,8 @@ static ARIARoleMap* createARIARoleMap()

{ "menu", MenuRole },

{ "menubar", MenuBarRole },

{ "menuitem", MenuItemRole },

- { "menuitemcheckbox", MenuItemRole },

- { "menuitemradio", MenuItemRole },

+ { "menuitemcheckbox", MenuItemCheckBoxRole },

+ { "menuitemradio", MenuItemRadioRole },

{ "note", NoteRole },

{ "navigation", NavigationRole },

{ "none", NoneRole },

@@ -202,6 +202,8 @@ bool AXObject::isMenuRelated() const

case MenuBarRole:

case MenuButtonRole:

case MenuItemRole:

+ case MenuItemCheckBoxRole:

+ case MenuItemRadioRole:

return true;

default:

return false;

« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | public/web/WebAXEnums.h » ('J')