Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Side by Side Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 629003003: Adding roles in Blink side to expose menuitemcheckbox & menuitemradio role with correct IA2 role. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/accessibility/AXObject.h » ('j') | public/web/WebAXEnums.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1202 matching lines...) Expand 10 before | Expand all | Expand 10 after
1213 case PopUpButtonRole: 1213 case PopUpButtonRole:
1214 // Native popup buttons should not use their button children's text as a title. That value is retrieved through stringValue(). 1214 // Native popup buttons should not use their button children's text as a title. That value is retrieved through stringValue().
1215 if (isHTMLSelectElement(*node)) 1215 if (isHTMLSelectElement(*node))
1216 return String(); 1216 return String();
1217 case ButtonRole: 1217 case ButtonRole:
1218 case ToggleButtonRole: 1218 case ToggleButtonRole:
1219 case CheckBoxRole: 1219 case CheckBoxRole:
1220 case ListBoxOptionRole: 1220 case ListBoxOptionRole:
1221 case MenuButtonRole: 1221 case MenuButtonRole:
1222 case MenuItemRole: 1222 case MenuItemRole:
1223 case MenuItemCheckBoxRole:
1224 case MenuItemRadioRole:
1223 case RadioButtonRole: 1225 case RadioButtonRole:
1224 case TabRole: 1226 case TabRole:
1225 return textUnderElement(); 1227 return textUnderElement();
1226 // SVGRoots should not use the text under itself as a title. That could incl ude the text of objects like <text>. 1228 // SVGRoots should not use the text under itself as a title. That could incl ude the text of objects like <text>.
1227 case SVGRootRole: 1229 case SVGRootRole:
1228 return String(); 1230 return String();
1229 default: 1231 default:
1230 break; 1232 break;
1231 } 1233 }
1232 1234
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
1465 1467
1466 if (isHTMLSelectElement(*node)) 1468 if (isHTMLSelectElement(*node))
1467 return toElement(node); 1469 return toElement(node);
1468 1470
1469 switch (roleValue()) { 1471 switch (roleValue()) {
1470 case ButtonRole: 1472 case ButtonRole:
1471 case PopUpButtonRole: 1473 case PopUpButtonRole:
1472 case ToggleButtonRole: 1474 case ToggleButtonRole:
1473 case TabRole: 1475 case TabRole:
1474 case MenuItemRole: 1476 case MenuItemRole:
1477 case MenuItemCheckBoxRole:
1478 case MenuItemRadioRole:
1475 case ListItemRole: 1479 case ListItemRole:
1476 return toElement(node); 1480 return toElement(node);
1477 default: 1481 default:
1478 break; 1482 break;
1479 } 1483 }
1480 1484
1481 Element* elt = anchorElement(); 1485 Element* elt = anchorElement();
1482 if (!elt) 1486 if (!elt)
1483 elt = mouseButtonListener(); 1487 elt = mouseButtonListener();
1484 return elt; 1488 return elt;
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
1737 float range = maxValueForRange() - minValueForRange(); 1741 float range = maxValueForRange() - minValueForRange();
1738 float value = valueForRange(); 1742 float value = valueForRange();
1739 1743
1740 value += range * (percentChange / 100); 1744 value += range * (percentChange / 100);
1741 setValue(String::number(value)); 1745 setValue(String::number(value));
1742 1746
1743 axObjectCache()->postNotification(node(), AXObjectCache::AXValueChanged, tru e); 1747 axObjectCache()->postNotification(node(), AXObjectCache::AXValueChanged, tru e);
1744 } 1748 }
1745 1749
1746 } // namespace blink 1750 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/core/accessibility/AXObject.h » ('j') | public/web/WebAXEnums.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698