Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 628883002: replace OVERRIDE and FINAL with override and final in chromeos/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
armansito, satorux1, dcheng
CC:
chromium-reviews, extensions-reviews_chromium.org, derat+watch_chromium.org, hashimoto+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, dkrahn+watch_chromium.org, nona+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in chromeos/ BUG=417463 Committed: https://crrev.com/4f4cf14943aba9f3ea42f631f9eb491ce0c87857 Cr-Commit-Position: refs/heads/master@{#298229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1243 lines, -1243 lines) Patch
M chromeos/attestation/mock_attestation_flow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler_stub.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chromeos/audio/cras_audio_handler.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chromeos/audio/cras_audio_handler_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chromeos/cert_loader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/cert_loader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/cryptohome/async_method_caller.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M chromeos/cryptohome/homedir_methods.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chromeos/cryptohome/homedir_methods_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/cryptohome/system_salt_getter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/blocking_method_caller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/bluetooth_adapter_client.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M chromeos/dbus/bluetooth_agent_manager_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chromeos/dbus/bluetooth_device_client.cc View 15 chunks +16 lines, -16 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_characteristic_client.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_characteristic_service_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/bluetooth_gatt_descriptor_client.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_descriptor_service_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/bluetooth_gatt_manager_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_service_client.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chromeos/dbus/bluetooth_input_client.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chromeos/dbus/bluetooth_profile_manager_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/cras_audio_client.cc View 14 chunks +17 lines, -17 lines 0 comments Download
M chromeos/dbus/cras_audio_client_stub_impl.h View 1 chunk +17 lines, -17 lines 0 comments Download
M chromeos/dbus/cros_disks_client.cc View 15 chunks +20 lines, -20 lines 0 comments Download
M chromeos/dbus/cryptohome_client.cc View 55 chunks +60 lines, -60 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.cc View 17 chunks +17 lines, -17 lines 0 comments Download
M chromeos/dbus/easy_unlock_client.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_adapter_client.h View 1 chunk +11 lines, -11 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_agent_manager_client.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_device_client.h View 1 chunk +16 lines, -16 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_characteristic_client.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_characteristic_service_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_descriptor_client.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_descriptor_service_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_manager_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_service_client.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_input_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_profile_manager_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_cros_disks_client.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.h View 2 chunks +60 lines, -60 lines 0 comments Download
M chromeos/dbus/fake_debug_daemon_client.h View 1 chunk +17 lines, -17 lines 0 comments Download
M chromeos/dbus/fake_easy_unlock_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_gsm_sms_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chromeos/dbus/fake_image_burner_client.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_introspectable_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_lorgnette_manager_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_modem_messaging_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_nfc_adapter_client.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chromeos/dbus/fake_nfc_device_client.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chromeos/dbus/fake_nfc_manager_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chromeos/dbus/fake_nfc_record_client.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chromeos/dbus/fake_nfc_tag_client.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chromeos/dbus/fake_permission_broker_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_power_manager_client.h View 1 chunk +20 lines, -20 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.h View 1 chunk +23 lines, -23 lines 0 comments Download
M chromeos/dbus/fake_shill_device_client.h View 1 chunk +22 lines, -22 lines 0 comments Download
M chromeos/dbus/fake_shill_ipconfig_client.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.h View 1 chunk +38 lines, -38 lines 0 comments Download
M chromeos/dbus/fake_shill_profile_client.h View 1 chunk +14 lines, -14 lines 0 comments Download
M chromeos/dbus/fake_shill_service_client.h View 2 chunks +23 lines, -23 lines 0 comments Download
M chromeos/dbus/fake_sms_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_system_clock_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chromeos/dbus/fake_update_engine_client.h View 1 chunk +11 lines, -11 lines 0 comments Download
M chromeos/dbus/gsm_sms_client.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chromeos/dbus/gsm_sms_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/image_burner_client.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chromeos/dbus/introspectable_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/lorgnette_manager_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/modem_messaging_client.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chromeos/dbus/modem_messaging_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/nfc_adapter_client.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M chromeos/dbus/nfc_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/nfc_device_client.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M chromeos/dbus/nfc_manager_client.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/dbus/nfc_property_set.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chromeos/dbus/nfc_record_client.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M chromeos/dbus/nfc_tag_client.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M chromeos/dbus/permission_broker_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/pipe_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/power_manager_client.cc View 12 chunks +40 lines, -40 lines 0 comments Download
M chromeos/dbus/power_policy_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/power_policy_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 20 chunks +46 lines, -46 lines 0 comments Download
M chromeos/dbus/shill_client_unittest_base.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chromeos/dbus/shill_device_client.cc View 13 chunks +17 lines, -17 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chromeos/dbus/shill_manager_client.cc View 16 chunks +20 lines, -20 lines 0 comments Download
M chromeos/dbus/shill_profile_client.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chromeos/dbus/shill_service_client.cc View 12 chunks +15 lines, -15 lines 0 comments Download
M chromeos/dbus/sms_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/system_clock_client.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chromeos/dbus/update_engine_client.cc View 10 chunks +27 lines, -27 lines 0 comments Download
M chromeos/disks/disk_mount_manager.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M chromeos/ime/fake_ime_keyboard.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chromeos/ime/fake_input_method_delegate.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/ime/ime_keyboard_x11.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M chromeos/ime/ime_keyboard_x11_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/ime/mock_component_extension_ime_manager_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.h View 4 chunks +14 lines, -14 lines 0 comments Download
M chromeos/login/auth/mock_authenticator.h View 1 chunk +13 lines, -13 lines 0 comments Download
M chromeos/login/auth/mock_url_fetchers.h View 6 chunks +6 lines, -6 lines 0 comments Download
M chromeos/login/auth/online_attempt.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/login/auth/online_attempt_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/auth/test_attempt_state.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chromeos/login/login_state_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/client_cert_resolver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/client_cert_resolver_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/device_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/dhcp_proxy_script_fetcher_chromeos.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chromeos/network/fake_network_device_handler.h View 1 chunk +13 lines, -13 lines 0 comments Download
M chromeos/network/geolocation_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/geolocation_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/host_resolver_impl_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/host_resolver_impl_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/host_resolver_impl_chromeos_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.h View 1 chunk +16 lines, -16 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/network_cert_migrator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_cert_migrator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/network_change_notifier_chromeos.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/network_change_notifier_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_change_notifier_factory_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_configuration_handler_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chromeos/network/network_connection_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chromeos/network/network_connection_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/network_device_handler_impl.h View 1 chunk +14 lines, -14 lines 0 comments Download
M chromeos/network/network_device_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/network_event_log_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_profile_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_sms_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_sms_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/network_sms_handler_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/network_state.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/network_state_handler.h View 2 chunks +10 lines, -10 lines 0 comments Download
M chromeos/network/network_state_handler_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chromeos/network/network_state_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_merger.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chromeos/network/onc/onc_normalizer.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_validator.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chromeos/network/portal_detector/network_portal_detector.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chromeos/network/portal_detector/network_portal_detector_strategy.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chromeos/network/shill_property_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_handler_unittest.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M chromeos/process_proxy/process_output_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/process_proxy/process_proxy_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chromeos/settings/timezone_settings.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chromeos/system/statistics_provider.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/tpm_token_loader.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Mostyn Bramley-Moore
@satorux: can you give this a thumbs-up? The script I used to make this change ...
6 years, 2 months ago (2014-10-04 07:52:49 UTC) #1
satorux1
LGTM. Thank you for cleaning this up.
6 years, 2 months ago (2014-10-06 00:35:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628883002/1
6 years, 2 months ago (2014-10-06 06:05:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/15584)
6 years, 2 months ago (2014-10-06 06:14:51 UTC) #6
Mostyn Bramley-Moore
@armansito: can you give an OK for chromeos/network/ ?
6 years, 2 months ago (2014-10-06 07:18:30 UTC) #8
armansito
lgtm
6 years, 2 months ago (2014-10-06 13:36:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628883002/1
6 years, 2 months ago (2014-10-06 13:38:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8bb57306560e3e3e0f5298c189501f90124d66e2
6 years, 2 months ago (2014-10-06 13:58:03 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 13:58:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f4cf14943aba9f3ea42f631f9eb491ce0c87857
Cr-Commit-Position: refs/heads/master@{#298229}

Powered by Google App Engine
This is Rietveld 408576698