Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: chromeos/dbus/shill_manager_client.cc

Issue 628883002: replace OVERRIDE and FINAL with override and final in chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/dbus/shill_ipconfig_client.cc ('k') | chromeos/dbus/shill_profile_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/dbus/shill_manager_client.h" 5 #include "chromeos/dbus/shill_manager_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 11 matching lines...) Expand all
22 namespace { 22 namespace {
23 23
24 // The ShillManagerClient implementation. 24 // The ShillManagerClient implementation.
25 class ShillManagerClientImpl : public ShillManagerClient { 25 class ShillManagerClientImpl : public ShillManagerClient {
26 public: 26 public:
27 ShillManagerClientImpl() : proxy_(NULL) {} 27 ShillManagerClientImpl() : proxy_(NULL) {}
28 28
29 //////////////////////////////////// 29 ////////////////////////////////////
30 // ShillManagerClient overrides. 30 // ShillManagerClient overrides.
31 virtual void AddPropertyChangedObserver( 31 virtual void AddPropertyChangedObserver(
32 ShillPropertyChangedObserver* observer) OVERRIDE { 32 ShillPropertyChangedObserver* observer) override {
33 helper_->AddPropertyChangedObserver(observer); 33 helper_->AddPropertyChangedObserver(observer);
34 } 34 }
35 35
36 virtual void RemovePropertyChangedObserver( 36 virtual void RemovePropertyChangedObserver(
37 ShillPropertyChangedObserver* observer) OVERRIDE { 37 ShillPropertyChangedObserver* observer) override {
38 helper_->RemovePropertyChangedObserver(observer); 38 helper_->RemovePropertyChangedObserver(observer);
39 } 39 }
40 40
41 virtual void GetProperties(const DictionaryValueCallback& callback) OVERRIDE { 41 virtual void GetProperties(const DictionaryValueCallback& callback) override {
42 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 42 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
43 shill::kGetPropertiesFunction); 43 shill::kGetPropertiesFunction);
44 helper_->CallDictionaryValueMethod(&method_call, callback); 44 helper_->CallDictionaryValueMethod(&method_call, callback);
45 } 45 }
46 46
47 virtual void GetNetworksForGeolocation( 47 virtual void GetNetworksForGeolocation(
48 const DictionaryValueCallback& callback) OVERRIDE { 48 const DictionaryValueCallback& callback) override {
49 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 49 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
50 shill::kGetNetworksForGeolocation); 50 shill::kGetNetworksForGeolocation);
51 helper_->CallDictionaryValueMethod(&method_call, callback); 51 helper_->CallDictionaryValueMethod(&method_call, callback);
52 } 52 }
53 53
54 virtual void SetProperty(const std::string& name, 54 virtual void SetProperty(const std::string& name,
55 const base::Value& value, 55 const base::Value& value,
56 const base::Closure& callback, 56 const base::Closure& callback,
57 const ErrorCallback& error_callback) OVERRIDE { 57 const ErrorCallback& error_callback) override {
58 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 58 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
59 shill::kSetPropertyFunction); 59 shill::kSetPropertyFunction);
60 dbus::MessageWriter writer(&method_call); 60 dbus::MessageWriter writer(&method_call);
61 writer.AppendString(name); 61 writer.AppendString(name);
62 ShillClientHelper::AppendValueDataAsVariant(&writer, value); 62 ShillClientHelper::AppendValueDataAsVariant(&writer, value);
63 helper_->CallVoidMethodWithErrorCallback(&method_call, 63 helper_->CallVoidMethodWithErrorCallback(&method_call,
64 callback, 64 callback,
65 error_callback); 65 error_callback);
66 } 66 }
67 67
68 virtual void RequestScan(const std::string& type, 68 virtual void RequestScan(const std::string& type,
69 const base::Closure& callback, 69 const base::Closure& callback,
70 const ErrorCallback& error_callback) OVERRIDE { 70 const ErrorCallback& error_callback) override {
71 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 71 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
72 shill::kRequestScanFunction); 72 shill::kRequestScanFunction);
73 dbus::MessageWriter writer(&method_call); 73 dbus::MessageWriter writer(&method_call);
74 writer.AppendString(type); 74 writer.AppendString(type);
75 helper_->CallVoidMethodWithErrorCallback(&method_call, 75 helper_->CallVoidMethodWithErrorCallback(&method_call,
76 callback, 76 callback,
77 error_callback); 77 error_callback);
78 } 78 }
79 79
80 virtual void EnableTechnology( 80 virtual void EnableTechnology(
81 const std::string& type, 81 const std::string& type,
82 const base::Closure& callback, 82 const base::Closure& callback,
83 const ErrorCallback& error_callback) OVERRIDE { 83 const ErrorCallback& error_callback) override {
84 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 84 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
85 shill::kEnableTechnologyFunction); 85 shill::kEnableTechnologyFunction);
86 dbus::MessageWriter writer(&method_call); 86 dbus::MessageWriter writer(&method_call);
87 writer.AppendString(type); 87 writer.AppendString(type);
88 helper_->CallVoidMethodWithErrorCallback(&method_call, 88 helper_->CallVoidMethodWithErrorCallback(&method_call,
89 callback, 89 callback,
90 error_callback); 90 error_callback);
91 } 91 }
92 92
93 virtual void DisableTechnology( 93 virtual void DisableTechnology(
94 const std::string& type, 94 const std::string& type,
95 const base::Closure& callback, 95 const base::Closure& callback,
96 const ErrorCallback& error_callback) OVERRIDE { 96 const ErrorCallback& error_callback) override {
97 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 97 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
98 shill::kDisableTechnologyFunction); 98 shill::kDisableTechnologyFunction);
99 dbus::MessageWriter writer(&method_call); 99 dbus::MessageWriter writer(&method_call);
100 writer.AppendString(type); 100 writer.AppendString(type);
101 helper_->CallVoidMethodWithErrorCallback(&method_call, 101 helper_->CallVoidMethodWithErrorCallback(&method_call,
102 callback, 102 callback,
103 error_callback); 103 error_callback);
104 } 104 }
105 105
106 virtual void ConfigureService( 106 virtual void ConfigureService(
107 const base::DictionaryValue& properties, 107 const base::DictionaryValue& properties,
108 const ObjectPathCallback& callback, 108 const ObjectPathCallback& callback,
109 const ErrorCallback& error_callback) OVERRIDE { 109 const ErrorCallback& error_callback) override {
110 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 110 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
111 shill::kConfigureServiceFunction); 111 shill::kConfigureServiceFunction);
112 dbus::MessageWriter writer(&method_call); 112 dbus::MessageWriter writer(&method_call);
113 ShillClientHelper::AppendServicePropertiesDictionary(&writer, properties); 113 ShillClientHelper::AppendServicePropertiesDictionary(&writer, properties);
114 helper_->CallObjectPathMethodWithErrorCallback(&method_call, 114 helper_->CallObjectPathMethodWithErrorCallback(&method_call,
115 callback, 115 callback,
116 error_callback); 116 error_callback);
117 } 117 }
118 118
119 virtual void ConfigureServiceForProfile( 119 virtual void ConfigureServiceForProfile(
120 const dbus::ObjectPath& profile_path, 120 const dbus::ObjectPath& profile_path,
121 const base::DictionaryValue& properties, 121 const base::DictionaryValue& properties,
122 const ObjectPathCallback& callback, 122 const ObjectPathCallback& callback,
123 const ErrorCallback& error_callback) OVERRIDE { 123 const ErrorCallback& error_callback) override {
124 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 124 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
125 shill::kConfigureServiceForProfileFunction); 125 shill::kConfigureServiceForProfileFunction);
126 dbus::MessageWriter writer(&method_call); 126 dbus::MessageWriter writer(&method_call);
127 writer.AppendObjectPath(dbus::ObjectPath(profile_path)); 127 writer.AppendObjectPath(dbus::ObjectPath(profile_path));
128 ShillClientHelper::AppendServicePropertiesDictionary(&writer, properties); 128 ShillClientHelper::AppendServicePropertiesDictionary(&writer, properties);
129 helper_->CallObjectPathMethodWithErrorCallback(&method_call, 129 helper_->CallObjectPathMethodWithErrorCallback(&method_call,
130 callback, 130 callback,
131 error_callback); 131 error_callback);
132 } 132 }
133 133
134 virtual void GetService( 134 virtual void GetService(
135 const base::DictionaryValue& properties, 135 const base::DictionaryValue& properties,
136 const ObjectPathCallback& callback, 136 const ObjectPathCallback& callback,
137 const ErrorCallback& error_callback) OVERRIDE { 137 const ErrorCallback& error_callback) override {
138 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 138 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
139 shill::kGetServiceFunction); 139 shill::kGetServiceFunction);
140 dbus::MessageWriter writer(&method_call); 140 dbus::MessageWriter writer(&method_call);
141 ShillClientHelper::AppendServicePropertiesDictionary(&writer, properties); 141 ShillClientHelper::AppendServicePropertiesDictionary(&writer, properties);
142 helper_->CallObjectPathMethodWithErrorCallback(&method_call, 142 helper_->CallObjectPathMethodWithErrorCallback(&method_call,
143 callback, 143 callback,
144 error_callback); 144 error_callback);
145 } 145 }
146 146
147 virtual void VerifyDestination(const VerificationProperties& properties, 147 virtual void VerifyDestination(const VerificationProperties& properties,
148 const BooleanCallback& callback, 148 const BooleanCallback& callback,
149 const ErrorCallback& error_callback) OVERRIDE { 149 const ErrorCallback& error_callback) override {
150 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 150 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
151 shill::kVerifyDestinationFunction); 151 shill::kVerifyDestinationFunction);
152 dbus::MessageWriter writer(&method_call); 152 dbus::MessageWriter writer(&method_call);
153 writer.AppendString(properties.certificate); 153 writer.AppendString(properties.certificate);
154 writer.AppendString(properties.public_key); 154 writer.AppendString(properties.public_key);
155 writer.AppendString(properties.nonce); 155 writer.AppendString(properties.nonce);
156 writer.AppendString(properties.signed_data); 156 writer.AppendString(properties.signed_data);
157 writer.AppendString(properties.device_serial); 157 writer.AppendString(properties.device_serial);
158 writer.AppendString(properties.device_ssid); 158 writer.AppendString(properties.device_ssid);
159 writer.AppendString(properties.device_bssid); 159 writer.AppendString(properties.device_bssid);
160 helper_->CallBooleanMethodWithErrorCallback( 160 helper_->CallBooleanMethodWithErrorCallback(
161 &method_call, callback, error_callback); 161 &method_call, callback, error_callback);
162 } 162 }
163 163
164 virtual void VerifyAndEncryptCredentials( 164 virtual void VerifyAndEncryptCredentials(
165 const VerificationProperties& properties, 165 const VerificationProperties& properties,
166 const std::string& service_path, 166 const std::string& service_path,
167 const StringCallback& callback, 167 const StringCallback& callback,
168 const ErrorCallback& error_callback) OVERRIDE { 168 const ErrorCallback& error_callback) override {
169 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 169 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
170 shill::kVerifyAndEncryptCredentialsFunction); 170 shill::kVerifyAndEncryptCredentialsFunction);
171 dbus::MessageWriter writer(&method_call); 171 dbus::MessageWriter writer(&method_call);
172 writer.AppendString(properties.certificate); 172 writer.AppendString(properties.certificate);
173 writer.AppendString(properties.public_key); 173 writer.AppendString(properties.public_key);
174 writer.AppendString(properties.nonce); 174 writer.AppendString(properties.nonce);
175 writer.AppendString(properties.signed_data); 175 writer.AppendString(properties.signed_data);
176 writer.AppendString(properties.device_serial); 176 writer.AppendString(properties.device_serial);
177 writer.AppendString(properties.device_ssid); 177 writer.AppendString(properties.device_ssid);
178 writer.AppendString(properties.device_bssid); 178 writer.AppendString(properties.device_bssid);
179 writer.AppendObjectPath(dbus::ObjectPath(service_path)); 179 writer.AppendObjectPath(dbus::ObjectPath(service_path));
180 helper_->CallStringMethodWithErrorCallback( 180 helper_->CallStringMethodWithErrorCallback(
181 &method_call, callback, error_callback); 181 &method_call, callback, error_callback);
182 } 182 }
183 183
184 virtual void VerifyAndEncryptData( 184 virtual void VerifyAndEncryptData(
185 const VerificationProperties& properties, 185 const VerificationProperties& properties,
186 const std::string& data, 186 const std::string& data,
187 const StringCallback& callback, 187 const StringCallback& callback,
188 const ErrorCallback& error_callback) OVERRIDE { 188 const ErrorCallback& error_callback) override {
189 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 189 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
190 shill::kVerifyAndEncryptDataFunction); 190 shill::kVerifyAndEncryptDataFunction);
191 dbus::MessageWriter writer(&method_call); 191 dbus::MessageWriter writer(&method_call);
192 writer.AppendString(properties.certificate); 192 writer.AppendString(properties.certificate);
193 writer.AppendString(properties.public_key); 193 writer.AppendString(properties.public_key);
194 writer.AppendString(properties.nonce); 194 writer.AppendString(properties.nonce);
195 writer.AppendString(properties.signed_data); 195 writer.AppendString(properties.signed_data);
196 writer.AppendString(properties.device_serial); 196 writer.AppendString(properties.device_serial);
197 writer.AppendString(properties.device_ssid); 197 writer.AppendString(properties.device_ssid);
198 writer.AppendString(properties.device_bssid); 198 writer.AppendString(properties.device_bssid);
199 writer.AppendString(data); 199 writer.AppendString(data);
200 helper_->CallStringMethodWithErrorCallback( 200 helper_->CallStringMethodWithErrorCallback(
201 &method_call, callback, error_callback); 201 &method_call, callback, error_callback);
202 } 202 }
203 203
204 virtual void ConnectToBestServices( 204 virtual void ConnectToBestServices(
205 const base::Closure& callback, 205 const base::Closure& callback,
206 const ErrorCallback& error_callback) OVERRIDE { 206 const ErrorCallback& error_callback) override {
207 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 207 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
208 shill::kConnectToBestServicesFunction); 208 shill::kConnectToBestServicesFunction);
209 helper_->CallVoidMethodWithErrorCallback(&method_call, 209 helper_->CallVoidMethodWithErrorCallback(&method_call,
210 callback, 210 callback,
211 error_callback); 211 error_callback);
212 } 212 }
213 213
214 virtual void AddWakeOnPacketConnection( 214 virtual void AddWakeOnPacketConnection(
215 const net::IPEndPoint& ip_endpoint, 215 const net::IPEndPoint& ip_endpoint,
216 const base::Closure& callback, 216 const base::Closure& callback,
217 const ErrorCallback& error_callback) OVERRIDE { 217 const ErrorCallback& error_callback) override {
218 if (ip_endpoint.address().empty()) { 218 if (ip_endpoint.address().empty()) {
219 LOG(ERROR) << "AddWakeOnPacketConnection: null address"; 219 LOG(ERROR) << "AddWakeOnPacketConnection: null address";
220 return; 220 return;
221 } 221 }
222 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 222 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
223 shill::kAddWakeOnPacketConnectionFunction); 223 shill::kAddWakeOnPacketConnectionFunction);
224 dbus::MessageWriter writer(&method_call); 224 dbus::MessageWriter writer(&method_call);
225 writer.AppendString(net::IPAddressToString(ip_endpoint.address())); 225 writer.AppendString(net::IPAddressToString(ip_endpoint.address()));
226 helper_->CallVoidMethodWithErrorCallback(&method_call, 226 helper_->CallVoidMethodWithErrorCallback(&method_call,
227 callback, 227 callback,
228 error_callback); 228 error_callback);
229 } 229 }
230 230
231 virtual void RemoveWakeOnPacketConnection( 231 virtual void RemoveWakeOnPacketConnection(
232 const net::IPEndPoint& ip_endpoint, 232 const net::IPEndPoint& ip_endpoint,
233 const base::Closure& callback, 233 const base::Closure& callback,
234 const ErrorCallback& error_callback) OVERRIDE { 234 const ErrorCallback& error_callback) override {
235 if (ip_endpoint.address().empty()) { 235 if (ip_endpoint.address().empty()) {
236 LOG(ERROR) << "RemoveWakeOnPacketConnection: null address"; 236 LOG(ERROR) << "RemoveWakeOnPacketConnection: null address";
237 return; 237 return;
238 } 238 }
239 dbus::MethodCall method_call(shill::kFlimflamManagerInterface, 239 dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
240 shill::kRemoveWakeOnPacketConnectionFunction); 240 shill::kRemoveWakeOnPacketConnectionFunction);
241 dbus::MessageWriter writer(&method_call); 241 dbus::MessageWriter writer(&method_call);
242 writer.AppendString(net::IPAddressToString(ip_endpoint.address())); 242 writer.AppendString(net::IPAddressToString(ip_endpoint.address()));
243 helper_->CallVoidMethodWithErrorCallback(&method_call, 243 helper_->CallVoidMethodWithErrorCallback(&method_call,
244 callback, 244 callback,
245 error_callback); 245 error_callback);
246 } 246 }
247 247
248 virtual void RemoveAllWakeOnPacketConnections( 248 virtual void RemoveAllWakeOnPacketConnections(
249 const base::Closure& callback, 249 const base::Closure& callback,
250 const ErrorCallback& error_callback) OVERRIDE { 250 const ErrorCallback& error_callback) override {
251 dbus::MethodCall method_call( 251 dbus::MethodCall method_call(
252 shill::kFlimflamManagerInterface, 252 shill::kFlimflamManagerInterface,
253 shill::kRemoveAllWakeOnPacketConnectionsFunction); 253 shill::kRemoveAllWakeOnPacketConnectionsFunction);
254 helper_->CallVoidMethodWithErrorCallback(&method_call, 254 helper_->CallVoidMethodWithErrorCallback(&method_call,
255 callback, 255 callback,
256 error_callback); 256 error_callback);
257 } 257 }
258 258
259 virtual TestInterface* GetTestInterface() OVERRIDE { 259 virtual TestInterface* GetTestInterface() override {
260 return NULL; 260 return NULL;
261 } 261 }
262 262
263 protected: 263 protected:
264 virtual void Init(dbus::Bus* bus) OVERRIDE { 264 virtual void Init(dbus::Bus* bus) override {
265 proxy_ = bus->GetObjectProxy(shill::kFlimflamServiceName, 265 proxy_ = bus->GetObjectProxy(shill::kFlimflamServiceName,
266 dbus::ObjectPath(shill::kFlimflamServicePath)); 266 dbus::ObjectPath(shill::kFlimflamServicePath));
267 helper_.reset(new ShillClientHelper(proxy_)); 267 helper_.reset(new ShillClientHelper(proxy_));
268 helper_->MonitorPropertyChanged(shill::kFlimflamManagerInterface); 268 helper_->MonitorPropertyChanged(shill::kFlimflamManagerInterface);
269 } 269 }
270 270
271 private: 271 private:
272 dbus::ObjectProxy* proxy_; 272 dbus::ObjectProxy* proxy_;
273 scoped_ptr<ShillClientHelper> helper_; 273 scoped_ptr<ShillClientHelper> helper_;
274 274
(...skipping 12 matching lines...) Expand all
287 } 287 }
288 288
289 // ShillManagerClient::VerificationProperties implementation. 289 // ShillManagerClient::VerificationProperties implementation.
290 ShillManagerClient::VerificationProperties::VerificationProperties() { 290 ShillManagerClient::VerificationProperties::VerificationProperties() {
291 } 291 }
292 292
293 ShillManagerClient::VerificationProperties::~VerificationProperties() { 293 ShillManagerClient::VerificationProperties::~VerificationProperties() {
294 } 294 }
295 295
296 } // namespace chromeos 296 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/dbus/shill_ipconfig_client.cc ('k') | chromeos/dbus/shill_profile_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698