Mojo JS bindings: simplify mojo.connectToService() usage - Part 1

Mojo JS bindings: simplify mojo.connectToService() usage - Part 1

This is an incremental step towards the goals listed in crbug.com/419160

The Mojo JS bindings now export an object for each interface. The object itemizes the interface values needed at runtime. Here's an example:

  exports.Service = {
    name: 'sample::Service',
    proxyClass: ServiceProxy,
    stubClass: ServiceStub,
    validateRequest: validateServiceRequest,
    validateResponse: null,
  };

I've removed the individual exports of the proxy and stub class names as well as the interface "NAME_" property that was added to proxy and stub classes.

When possible, the object for an interface's client is added.  For example:

  exports.Service.client = exports.ServiceClient;

The next step (next patch) will automatically create a stub client object that delegates to a user supplied object.

BUG=419160
Committed: https://crrev.com/39b01de0b16d731ce3fe33d0f7f5a0973d98729f
Cr-Commit-Position: refs/heads/master@{#298509}

[hansmuller, 2014-10-03 22:16:29]

hansmuller@chromium.org changed reviewers:
+ mpcomplete@google.com

[hansmuller, 2014-10-03 22:16:30]

This is logically a pretty small change however the blast area is big enough
that I thought would be best to break it out.

PTAL, Thanks.

[Matt Perry, 2014-10-03 22:57:48]

mpcomplete@chromium.org changed reviewers:
+ mpcomplete@chromium.org

[Matt Perry, 2014-10-03 22:57:49]

Awesome, so glad you're cleaning this up.

https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
File
mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl
(right):

https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl:162:
{#--- Enums #}
These enums and constants can now be exported on the main interface class you
export. No more duplicating them across the Proxy and Stub!

https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
File mojo/public/tools/bindings/generators/js_templates/module.js.tmpl (right):

https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/js_templates/module.js.tmpl:49:
exports.{{interface.name}} = {
I think this block belongs in interface_definition.tmpl. Then here, just do
  exports.{{interface.name}} = {{interface.name}};

[hansmuller, 2014-10-06 19:05:19]

I've made the the changes you suggested. I added a small struct test for scoped
enums and constants, even though sample_services_unittests.js does cover the
same territory.

https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
File
mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl
(right):

https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl:162:
{#--- Enums #}
On 2014/10/03 22:57:49, Matt Perry wrote:
> These enums and constants can now be exported on the main interface class you
> export. No more duplicating them across the Proxy and Stub!

Good point. I've done that.

https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
File mojo/public/tools/bindings/generators/js_templates/module.js.tmpl (right):

https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/js_templates/module.js.tmpl:49:
exports.{{interface.name}} = {
On 2014/10/03 22:57:49, Matt Perry wrote:
> I think this block belongs in interface_definition.tmpl. Then here, just do
>   exports.{{interface.name}} = {{interface.name}};

Done.

[hansmuller, 2014-10-06 19:09:07]

On 2014/10/06 19:05:19, hansmuller wrote:
> I've made the the changes you suggested. I added a small struct test for
scoped
> enums and constants, even though sample_services_unittests.js does cover the
> same territory.
> 
>
https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
> File
> mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl
> (right):
> 
>
https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
>
mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl:162:
> {#--- Enums #}
> On 2014/10/03 22:57:49, Matt Perry wrote:
> > These enums and constants can now be exported on the main interface class
you
> > export. No more duplicating them across the Proxy and Stub!
> 
> Good point. I've done that.
> 
>
https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
> File mojo/public/tools/bindings/generators/js_templates/module.js.tmpl
(right):
> 
>
https://codereview.chromium.org/628763002/diff/1/mojo/public/tools/bindings/g...
> mojo/public/tools/bindings/generators/js_templates/module.js.tmpl:49:
> exports.{{interface.name}} = {
> On 2014/10/03 22:57:49, Matt Perry wrote:
> > I think this block belongs in interface_definition.tmpl. Then here, just do
> >   exports.{{interface.name}} = {{interface.name}};
> 
> Done.

Note: this isn't ready for a second round of review yet, I forgot to cleanup the
interface struct/const template definitions.

[Matt Perry, 2014-10-06 19:13:27]

https://codereview.chromium.org/628763002/diff/20001/mojo/public/tools/bindin...
File mojo/public/tools/bindings/generators/js_templates/module.js.tmpl (right):

https://codereview.chromium.org/628763002/diff/20001/mojo/public/tools/bindin...
mojo/public/tools/bindings/generators/js_templates/module.js.tmpl:50: {#---
Interface Enums #}
I think these enum and constant definitions belong in interface_definition.tmpl
as well.

[hansmuller, 2014-10-06 19:32:58]

I believe everything is in order now. PTAL.

[Matt Perry, 2014-10-06 19:35:41]

LGTM

https://codereview.chromium.org/628763002/diff/40001/mojo/public/tools/bindin...
File
mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl
(right):

https://codereview.chromium.org/628763002/diff/40001/mojo/public/tools/bindin...
mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl:160:
{%-   if interface|has_callbacks %}
nit: this and other {%} commands below at the same indent level should line up
(only 1 space after the {%- ).

[hansmuller, 2014-10-06 19:44:43]

The CQ bit was checked by hansmuller@chromium.org

[commit-bot: I haz the power, 2014-10-06 19:46:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/628763002/60001

[commit-bot: I haz the power, 2014-10-06 20:10:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-06 20:10:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2014-10-06 22:58:54]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2014-10-06 22:58:55]

ui and chrome LGTM

[Ken Rockot(use gerrit already), 2014-10-07 15:55:00]

rockot@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2014-10-07 15:57:56]

extensions/renderer lgtm

[hansmuller, 2014-10-07 15:59:51]

The CQ bit was checked by hansmuller@chromium.org

[commit-bot: I haz the power, 2014-10-07 16:01:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/628763002/60001

[commit-bot: I haz the power, 2014-10-07 17:04:02]

Committed patchset #4 (id:60001) as 7a30f2d702d76fa2521f835d6259c92a1766a8a9

[commit-bot: I haz the power, 2014-10-07 17:04:51]

Patchset 4 (id:??) landed as
https://crrev.com/39b01de0b16d731ce3fe33d0f7f5a0973d98729f
Cr-Commit-Position: refs/heads/master@{#298509}